Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter section headers to be anchor tags rather than headers #3416

Conversation

admilne
Copy link
Contributor

@admilne admilne commented Nov 6, 2024

What is the context of this PR?

Fixes #3400

The section navigation component has been updated to replace the heading tags with anchor tags for section headings.

How to review this PR

  1. Check the section headings can be hovered on and clicked on like any other link.
  2. Check the markup to ensure the section heading is now an anchor tag rather than a h2, h3, etc.
  3. This should be applicable for both horizontal and vertical section navigations.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@admilne admilne added the Bug Something isn't working label Nov 6, 2024
@admilne admilne requested a review from a team November 6, 2024 16:07
@admilne admilne self-assigned this Nov 6, 2024
Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit f70c8dd
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/6731eb0ea2c1a100084f22fe
😎 Deploy Preview https://deploy-preview-3416--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@rmccar rmccar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

…element-is-a-header-that-behaves-like-a-link
@admilne admilne merged commit fab100f into main Nov 11, 2024
25 checks passed
@admilne admilne deleted the fix/3400/vertical-section-navigation-active-element-is-a-header-that-behaves-like-a-link branch November 11, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical section navigation active element is a header that behaves like a link
4 participants