-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Button component test file to new format #3353
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are mainly just minor things but it would be good to be consistent with the way we are writing these tests. We need to make sure we use the correct names for params and the tests describe what they are testing
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
There are now a couple of new tests being added in #3418 that will need to be incorporated into this |
Ive realised we are missing tests for the following params, I think we need to add them:
|
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
What is the context of this PR?
139
Refactored the button macro.spec file as per the new format.
How to review this PR
Ask yourself....
run this test command to view the test results:
yarn test --testNamePattern="FOR: button"
Checklist
This needs to be completed by the person raising the PR.