-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align checkbox indent line with the checkboxes #3421
Merged
precious-onyenaucheya-ons
merged 6 commits into
main
from
feature/3384-align-checkbox-indent-line
Nov 13, 2024
Merged
Align checkbox indent line with the checkboxes #3421
precious-onyenaucheya-ons
merged 6 commits into
main
from
feature/3384-align-checkbox-indent-line
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
precious-onyenaucheya-ons
force-pushed
the
feature/3384-align-checkbox-indent-line
branch
from
November 12, 2024 14:25
a0f046b
to
514d3d6
Compare
Has something happened with the screenshots on this PR? None of them are rendering |
rmccar
approved these changes
Nov 13, 2024
admilne
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and looks good
precious-onyenaucheya-ons
deleted the
feature/3384-align-checkbox-indent-line
branch
November 13, 2024 15:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes #3384
This PR adjusts the alignment of the checkbox indent line, ensuring it is centered with the checkboxes. The left margin on the line has been increased for better alignment
How to review this PR
Checklist
This needs to be completed by the person raising the PR.