Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align checkbox indent line with the checkboxes #3421

Merged

Conversation

precious-onyenaucheya-ons
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Nov 11, 2024

What is the context of this PR?

Fixes #3384

This PR adjusts the alignment of the checkbox indent line, ensuring it is centered with the checkboxes. The left margin on the line has been increased for better alignment

How to review this PR

  • Check that all visual changes show the intended alignment.
  • Run the checkbox component locally and confirm that the indent line is now properly centered with the checkboxes

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Bug Something isn't working label Nov 11, 2024
Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit acee453
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/6734b35d0c894e0008c760cb
😎 Deploy Preview https://deploy-preview-3421--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team November 11, 2024 15:24
@precious-onyenaucheya-ons precious-onyenaucheya-ons force-pushed the feature/3384-align-checkbox-indent-line branch from a0f046b to 514d3d6 Compare November 12, 2024 14:25
@rmccar
Copy link
Contributor

rmccar commented Nov 13, 2024

Has something happened with the screenshots on this PR? None of them are rendering

Copy link
Contributor

@admilne admilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and looks good

@precious-onyenaucheya-ons precious-onyenaucheya-ons merged commit 31db5cc into main Nov 13, 2024
25 checks passed
@precious-onyenaucheya-ons precious-onyenaucheya-ons deleted the feature/3384-align-checkbox-indent-line branch November 13, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align checkbox indent line with checkboxes
3 participants