Update benchmark journey to test complex scenarios #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berroar
reviewed
Sep 20, 2023
|
We probably want to add a section with |
Yeah wouldn't be against this, I guess list collector repeating blocks is another more recent one we could consider adding as well? Don't think it's in there at the moment? |
…ollector repeating blocks
petechd
approved these changes
Oct 20, 2023
berroar
approved these changes
Oct 20, 2023
Co-authored-by: Rhys Berrow <[email protected]>
Yuyuutsu
deleted the
update-benchmark-journey-to-test-complex-scenarios
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Update
test_business_benchmarkto test runner under complex scenarios such as cross-section dependencies, list collectors etc. This card is linked to the PR in eq-survey-runner-benchmarkRemoved q-codes since I needed to update
data-version=0.0.3Trello Card
How to review
Test
test_business_benchmark.jsonand have a look if it tests all complex scenarios expected in the trello card.Checklist