Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to fields module #1214

Merged
merged 25 commits into from
Oct 4, 2023
Merged

Add type hints to fields module #1214

merged 25 commits into from
Oct 4, 2023

Conversation

liamtoozer
Copy link
Contributor

@liamtoozer liamtoozer commented Sep 26, 2023 •
edited
Loading

What is the context of this PR?

  • Added type hinting to the fields module to align with other modules with type hinting in place.
  • Updates to field handlers to include optional return types for UnboundField
  • Small tweaks to some unit tests to include enforced keyword args and more concrete types

How to review

Check to see if the type hints added to the module make sense, and any advice on how to improve would be great

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

Trello

@liamtoozer
Update MyPy ini file to include new location
6870d40
@liamtoozer
Move namedtuple choice types from select_handlers.py for type reuse
f26ff9a
@liamtoozer
Add type hints to select_field_with_detail_answer.py
2a75464
@liamtoozer
Tweak ChoiceWidgetRenderType tuple return types
9186f25
@liamtoozer
Add type hints to multiple_select_field_with_detail_answer.py
030262a
@liamtoozer
Add type hints to date_field.py and tweak caller positional arg to kwarg
9b73c02
@liamtoozer
Add missing future annotations to multiple_select_field_with_detail_a…
a19b425 
…nswer.py
@liamtoozer
Add decimal and int separator classes
5dcbd9d
@liamtoozer
Add type hints to max_text_area_field.py
32ef856
@liamtoozer
Add type hints to max_text_area_field.py and tweak caller positional …
a1de2cf 
…arg to kwarg
@liamtoozer
Add type hints to year_date_field.py
00df9ec
@liamtoozer
Tweak to validator kwarg
06f2c06
@liamtoozer
Tidy up
f95c9cf
@liamtoozer
Linting
ec6491f
@liamtoozer
Update tests to use named params now
f49225f
@liamtoozer liamtoozer added the help wanted Extra attention is needed label Sep 26, 2023
katie-gardner
katie-gardner reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@katie-gardner katie-gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍 added a few initial comments with a couple of questions/ideas

app/forms/fields/date_field.py Outdated Show resolved Hide resolved
app/forms/fields/integer_field_with_separator.py Outdated Show resolved Hide resolved
app/forms/fields/month_year_date_field.py Outdated Show resolved Hide resolved
app/forms/fields/year_date_field.py Outdated Show resolved Hide resolved
app/forms/fields/year_date_field.py Outdated Show resolved Hide resolved
app/forms/fields/year_date_field.py Outdated Show resolved Hide resolved
app/forms/fields/decimal_field_with_separator.py Outdated Show resolved Hide resolved
MebinAbraham
MebinAbraham reviewed Sep 26, 2023
View reviewed changes
app/forms/field_handlers/select_handlers.py Outdated Show resolved Hide resolved
mypy.ini Outdated Show resolved Hide resolved
app/forms/fields/year_date_field.py Outdated Show resolved Hide resolved
app/forms/fields/date_field.py Outdated Show resolved Hide resolved
app/forms/fields/month_year_date_field.py Outdated Show resolved Hide resolved
app/forms/fields/date_field.py Outdated Show resolved Hide resolved
app/forms/fields/date_field.py Outdated Show resolved Hide resolved
app/forms/validators.py Outdated Show resolved Hide resolved
MebinAbraham
MebinAbraham approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

petechd
petechd approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@petechd petechd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

katie-gardner
katie-gardner approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@katie-gardner katie-gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@liamtoozer liamtoozer merged commit 09b1c22 into main Oct 4, 2023
15 checks passed
@liamtoozer liamtoozer deleted the add-type-hints-to-fields-module branch October 4, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katie-gardner katie-gardner katie-gardner approved these changes

@petechd petechd petechd approved these changes

@MebinAbraham MebinAbraham MebinAbraham approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liamtoozer @MebinAbraham @petechd @katie-gardner