Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node V20 and drop support for Yarn in Validator #226

Merged
merged 11 commits into from
Dec 13, 2023

Conversation

VirajP1002
Copy link
Contributor

@VirajP1002 VirajP1002 commented Nov 21, 2023

What is the context of this PR?

Upgrade Node to version v20.10.0 and drop support for Yarn. Upgraded because Node.js 20 introduces important updates, bug fixes, and performance enhancements, ensuring our application remains up to date and secure.

How to review

  • Ensure Yarn has been removed and check the repository for any yarn that should not be there
  • Ensure new npm commands work as previously

Checklist

  • eq-translations updated to support any new schema keys which need translation

@VirajP1002
Copy link
Contributor Author

@VirajP1002 VirajP1002 changed the title Drop yarn and upgrade to node20 Upgrade to Node V20 and drop support for Yarn in Validator Nov 28, 2023
.pylintrc Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@katie-gardner katie-gardner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All make commands working as expected for me, nothing jumps out beyond the pylintrc comment 👍

ajv/app.js Show resolved Hide resolved
@VirajP1002 VirajP1002 merged commit 58f5bbd into main Dec 13, 2023
3 checks passed
@VirajP1002 VirajP1002 deleted the drop-yarn-and-upgrade-to-node20 branch December 13, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants