Prevent duplicate answer_ids across different list collectors

[liamtoozer]

What is the context of this PR?

An answer ID is globally unique in a schema, except for list collectors with the same name when used in one or more locations - it is correct that validation allows for this.

However, when there are multiple list collectors with a different name in a schema, the answer ID needs to be unique for each list collector child block (add, edit, and remove). Validation needs to be in place to ensure this.

The consequence of not validating this is that when Runner loads a schema with 2 list collectors, but both share an answer_id in the add_block, edit_block, or remove_block, if there is a routing rule in place to skip the first list collector then both list collectors are removed from the path, instead of just the first.

Additionally, we can also validate to make sure that a list collector child block answer ID is not used anywhere else in the schema if it's not for the same list.

Changes for this PR:

• I've updated the validate_other_list_collectors to include all list collectors in a schema so that we can also validate against those.
• As mentioned in the PR comment by Katie, we can also validate to ensure that the answer IDs in child blocks for every list collector are unique for the answer_ids across the rest of the schema

How to review

To review, try to validate the schema linked in the Trello ticket - it should now show the new validation error message.

Would appreciate any advice/feedback on improvements too!

[liamtoozer]

Bug: Validator allows duplicate answer ids in different list collectors

[katie-gardner]

Only functionally tested so far, but

• if I change the invalid example added in this PR so that the visitor LC has visitor-first-name I get no errors 👍
• If I then change the edit block to edit-visitor-first-name I get "Different list collectors populate a list using duplicate answer_ids in the add block" However the error is actually that the edit block and add block don't match, not that different LCs have duplicates, I think something has gone wrong?

[katie-gardner]

Ignore above, it does correctly pick up add/edit not matching 👍
There is a case that has slipped through, add/edit don't allow duplicates in different LCs now but two different list collectors could have the same answer-id in the remove block, might need small extension for this case

[katie-gardner]

Just a few minor comments 👍
Also this doesn't prevent having
block-1 with answer-1
list-collector with add-block with answer-1

Might not need fixing in this card? but it is a case that could get through

[katie-gardner]

Couple tiny non blockers, but all working for me now 👍

[MebinAbraham]

Just a few minor comments 👍 Also this doesn't prevent having block-1 with answer-1 list-collector with add-block with answer-1

Might not need fixing in this card? but it is a case that could get through

We should handle this given we are in this space. Happy for it to be a follow-up card to a separate PR. @liamtoozer can you raise a card or PR to fix this please but progress it next.

[liamtoozer]

Just a few minor comments 👍 Also this doesn't prevent having block-1 with answer-1 list-collector with add-block with answer-1
Might not need fixing in this card? but it is a case that could get through

We should handle this given we are in this space. Happy for it to be a follow-up card to a separate PR. @liamtoozer can you raise a card or PR to fix this please but progress it next.

Just to confirm - this should hopefully be covered in this PR now. Updated the PR description to reflect this

[berroar]

Tested, LGTM 👍