Migrate from openjdk to eclipse-temurin #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pricem14pc
commented
Nov 14, 2023
|
|
||
| ARG JAR_FILE=case.jar | ||
| RUN apt-get update |
There was a problem hiding this comment.
apt-get isn't installed on the alpine OS, but we don't install anything with apt-get in the case image anyway.
|
/deploy pricem |
|
Deploying to dev cluster with following parameters:
|
arroyoAle
approved these changes
Nov 27, 2023
|
/deploy robinm3 |
|
Deploying to dev cluster with following parameters:
|
matthew-robinson-ons
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
The openjdk base images are deprecated and no longer maintained. This migrates to the recommended eclipse-temurin image. This also migrates from the slim Linux OS to the alpine OS images as eclipse-temurin doesn't appear to offer slim. This reduces the image from ~305MB to ~143MB
How to test
Does the image build, does the application deploy, does the application start, are there any restarts, check the logs for errors, do the acceptance tests pass, check the logs and restarts (again!), check the image size, check the vulnerabilities