-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAS-940: Questionnaire Completion Rate Information #288
Merged
SteveScorfield
merged 9 commits into
main
from
add-timestamp-for-status-change-on-questionnaire
Feb 5, 2024
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
57835ed
Initial commit of code changes
SteveScorfield f449b33
auto patch increment
ras-rm-pr-bot 9e2c83e
Have updated the naming
SteveScorfield 6f17a0c
Updated changelog
SteveScorfield 4ec8d92
Have added an additional test to ensure that datetime is added
SteveScorfield 7a0b9c6
Have ran mvn format
SteveScorfield 42c4827
I have removed the test and just added the check within the first test
SteveScorfield 9914eba
Have made changes based on recommendations and have updated name of a…
SteveScorfield 3ba32fe
Forgot to format
SteveScorfield File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,6 @@ | |
import uk.gov.ons.ctp.response.casesvc.domain.model.CaseGroup; | ||
import uk.gov.ons.ctp.response.casesvc.domain.model.CaseGroupStatusAudit; | ||
import uk.gov.ons.ctp.response.casesvc.domain.repository.CaseGroupStatusAuditRepository; | ||
import uk.gov.ons.ctp.response.lib.common.time.DateTimeUtil; | ||
|
||
@Service | ||
public class CaseGroupAuditService { | ||
|
@@ -23,7 +22,7 @@ public void updateAuditTable(final CaseGroup caseGroup, final UUID partyId) { | |
auditEntity.setCaseGroupFK(caseGroup.getCaseGroupPK()); | ||
auditEntity.setStatus(caseGroup.getStatus()); | ||
auditEntity.setPartyId(partyId); | ||
auditEntity.setCreatedDateTime(DateTimeUtil.nowUTC()); | ||
auditEntity.setCreatedDateTime(caseGroup.getChangeStateTimestamp()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not convinced we use this table for anything, but right to update There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't believe it is but I thought for the sake on continuity to update it. |
||
log.with("audit_entity", auditEntity).debug("Updating the caseGroupStatus"); | ||
caseGroupStatusAuditRepository.saveAndFlush(auditEntity); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
src/main/resources/database/changes/release-36/add_timestamp_for_status_change.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
ALTER TABLE ONLY casesvc.casegroup | ||
ADD change_state_timestamp timestamp with time zone; |
11 changes: 11 additions & 0 deletions
11
src/main/resources/database/changes/release-36/changelog.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
databaseChangeLog: | ||
|
||
- changeSet: | ||
id: 36-1 | ||
author: Steve Scorfield | ||
changes: | ||
- sqlFile: | ||
comment: Add a timestamp column for when a status change is made to the survey for a respondent | ||
path: add_timestamp_for_status_change.sql | ||
relativeToChangelogFile: true | ||
splitStatements: false |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly strange name, I would expect it to align with the column? Isn't that status, I also find it more palatable flipping the words, so something like status_change_timestamp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I've renamed it.