Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAS-1030 Migrate from the spring cloud pubsub providers to google cloud Case service #290

Merged
merged 4 commits into from
Feb 19, 2024
Merged

RAS-1030 Migrate from the spring cloud pubsub providers to google cloud Case service #290

merged 4 commits into from
Feb 19, 2024

Conversation

arroyoAle
Copy link
Contributor

@arroyoAle arroyoAle commented Feb 15, 2024 •
edited
Loading

What and why?

This PR migrates to the google cloud provided starter for pub sub since the old spring cloud ones are no longer maintained

How to test?

  • deploy this PR to you envrionment
  • run the acceptance tests
  • complete the survey in frontstage
  • make sure that all the relevant pub sub messages are consumed and published properly by the case service

Jira

https://jira.ons.gov.uk/browse/RAS-1030

@arroyoAle arroyoAle marked this pull request as ready for review February 16, 2024 10:27
@matthew-robinson-ons
Copy link
Contributor

/deploy robinm3

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: robinm3

  • tag: pr-290

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

matthew-robinson-ons
matthew-robinson-ons approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@matthew-robinson-ons matthew-robinson-ons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything looks good

LJBabbage
LJBabbage approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@LJBabbage LJBabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually

@arroyoAle arroyoAle merged commit a69d047 into main Feb 19, 2024
1 check passed
@arroyoAle arroyoAle deleted the migrating-pubsub-providers branch February 19, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-robinson-ons matthew-robinson-ons matthew-robinson-ons approved these changes

@LJBabbage LJBabbage LJBabbage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arroyoAle @matthew-robinson-ons @ras-rm-pr-bot @LJBabbage