-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest cleanup #273
base: master
Are you sure you want to change the base?
Manifest cleanup #273
Conversation
Standardize the format to make it easier to compare. Some are using tabs, other spaces. No changes except the formatting. Signed-off-by: Fathi Boudra <[email protected]>
Instead of duplicating clone-depth to all the manifests, add it to common.xml as a default. Also include sync-, limited to 4 parallels jobs when synching. Signed-off-by: Fathi Boudra <[email protected]>
Always nice with clean-ups, but please have a look at this page as well to make sure that the information there still is up-to-date as well. We did try to use that as a guidance in the past to make them look the same, to make it easier to diff etc. . I.e., I see that after merging this, we need to update the docs page accordingly. |
@jbech-linaro thanks for the pointer. I'll have a look if we can automate this to check the guidance is followed or propose a doc update if it make sense. |
@@ -2,17 +2,17 @@ | |||
<manifest> | |||
<remote name="github" fetch="https://github.com"/> | |||
|
|||
<default remote="github" revision="master"/> | |||
<default remote="github" revision="master" sync-j="4" clone-depth="1"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What effect does this have on, for instance, the optee_os git? Will it also have a clone-depth of 1?
We'd like to clone the entire git history for all the optee* gits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a different -j
flag is passed to repo, will that take precedence?
Some manifests clean up in an attempt to standardize the style and make it easier to compare/use.