Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest cleanup #273

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Manifest cleanup #273

wants to merge 2 commits into from

Conversation

fboudra
Copy link

@fboudra fboudra commented Mar 18, 2024

Some manifests clean up in an attempt to standardize the style and make it easier to compare/use.

fboudra added 2 commits March 18, 2024 14:57
Standardize the format to make it easier to compare.
Some are using tabs, other spaces.
No changes except the formatting.

Signed-off-by: Fathi Boudra <[email protected]>
Instead of duplicating clone-depth to all the manifests, add it to
common.xml as a default. Also include sync-, limited to 4 parallels jobs
when synching.

Signed-off-by: Fathi Boudra <[email protected]>
@jbech-linaro
Copy link
Contributor

Always nice with clean-ups, but please have a look at this page as well to make sure that the information there still is up-to-date as well. We did try to use that as a guidance in the past to make them look the same, to make it easier to diff etc. . I.e., I see that after merging this, we need to update the docs page accordingly.

@fboudra
Copy link
Author

fboudra commented Mar 18, 2024

@jbech-linaro thanks for the pointer. I'll have a look if we can automate this to check the guidance is followed or propose a doc update if it make sense.

@@ -2,17 +2,17 @@
<manifest>
<remote name="github" fetch="https://github.com"/>

<default remote="github" revision="master"/>
<default remote="github" revision="master" sync-j="4" clone-depth="1"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What effect does this have on, for instance, the optee_os git? Will it also have a clone-depth of 1?
We'd like to clone the entire git history for all the optee* gits.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a different -j flag is passed to repo, will that take precedence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants