Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tee-supplicant: Enforce paths bound limits #366

Closed
wants to merge 1 commit into from
Closed

tee-supplicant: Enforce paths bound limits #366

wants to merge 1 commit into from

Conversation

TanelDettenborn
Copy link

@TanelDettenborn TanelDettenborn commented Dec 5, 2023 •
edited
Loading

Verify ta-path command line argument length and if snprintf() concated path is too long, then print an error message and terminate startup.

jforissier
jforissier reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tee-supplicant: Enforce paths bound limits

Switch from strdup and strcpy to strndup and strncpy. Also if snprintf-function concated path

Please add parentheses when mentioning functions: strdup(), strcpy() etc.

is too long, then print an error message and terminate startup.

Please wrap lines at 75 characters.

tee-supplicant/src/tee_supplicant.c Show resolved Hide resolved
@TanelDettenborn TanelDettenborn marked this pull request as draft December 5, 2023 11:12
@TanelDettenborn TanelDettenborn force-pushed the enforce_path_bound branch 2 times, most recently from 6da2ea9 to e220d04 Compare December 6, 2023 21:04
@TanelDettenborn TanelDettenborn marked this pull request as ready for review December 6, 2023 21:36
jenswi-linaro
jenswi-linaro reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@jenswi-linaro jenswi-linaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Jens Wiklander <[email protected]>

etienne-lms
etienne-lms reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked-by: Etienne Carriere <[email protected]>

@jforissier
Copy link
Contributor

Changed from >= to ==.

@jenswi-linaro is that OK with you?

tee-supplicant: Enforce paths bound limits
d21e324 
Verify "ta-path" command line argument length and if snprintf()
concated path is too long, then print an error message and
terminate startup.

Signed-off-by: Tanel Dettenborn <[email protected]>
@etienne-lms
Copy link
Contributor

Reviewed-by: Etienne Carriere <[email protected]>

@jenswi-linaro
Copy link
Contributor

Changed from >= to ==.

@jenswi-linaro is that OK with you?

Sure

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jan 8, 2024
@jforissier
Copy link
Contributor

Tags added, merged.

@jforissier jforissier closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etienne-lms etienne-lms etienne-lms left review comments

@jforissier jforissier jforissier left review comments

@jenswi-linaro jenswi-linaro jenswi-linaro left review comments

Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TanelDettenborn @jforissier @etienne-lms @jenswi-linaro