Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: native interrupt using DT bindings #218

Closed
wants to merge 2 commits into from

Conversation

etienne-lms
Copy link
Contributor

Adds information about the interrupt API functions to consider when using device tree to describe interrupts.

This change describes the API functions introduced by P-R OP-TEE/optee_os#6361.

Adds information about the interrupt API functions to consider when
using device tree to describe interrupts.

Signed-off-by: Etienne Carriere <[email protected]>
architecture/core.rst Outdated Show resolved Hide resolved
architecture/core.rst Outdated Show resolved Hide resolved
architecture/core.rst Outdated Show resolved Hide resolved

.. code-block:: c

static TEE_Result foo_probe(const void *fdt, int node, const void *compat)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better with an example in the code where it's implemented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this snippet illustrate well hiw it's expected to be used.
That said, you're right,n a real example would be better.
I have stm32 candidate drivers but they have not yet moved to this API.
Would you prefer this doc change to wait those are ready?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's OK for now, as long as it compiles if copied.

Fixes API function names and update dt_get_itr_func type callback
function description.

Signed-off-by: Etienne Carriere <[email protected]>
Copy link

github-actions bot commented Dec 7, 2023

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

Copy link
Contributor Author

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep alive.
I need to make a change in a stm32 driver to show an application of what this change describes, as requested in comment #r13829.
edited: discard my comment, I did'nt see you've already removed the label, thanks.

Copy link

github-actions bot commented Jan 7, 2024

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the Stale label Jan 7, 2024
@github-actions github-actions bot closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants