-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: native interrupt using DT bindings #218
Conversation
Adds information about the interrupt API functions to consider when using device tree to describe interrupts. Signed-off-by: Etienne Carriere <[email protected]>
|
||
.. code-block:: c | ||
|
||
static TEE_Result foo_probe(const void *fdt, int node, const void *compat) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better with an example in the code where it's implemented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this snippet illustrate well hiw it's expected to be used.
That said, you're right,n a real example would be better.
I have stm32 candidate drivers but they have not yet moved to this API.
Would you prefer this doc change to wait those are ready?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's OK for now, as long as it compiles if copied.
Fixes API function names and update dt_get_itr_func type callback function description. Signed-off-by: Etienne Carriere <[email protected]>
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep alive.
I need to make a change in a stm32 driver to show an application of what this change describes, as requested in comment #r13829.
edited: discard my comment, I did'nt see you've already removed the label, thanks.
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time. |
Adds information about the interrupt API functions to consider when using device tree to describe interrupts.
This change describes the API functions introduced by P-R OP-TEE/optee_os#6361.