Skip to content

Commit

Permalink
cancellation: Unmask inside of invoke command
Browse files Browse the repository at this point in the history
The specification seems to indicate (see #731)
that the cancellation mask is reset at the start of every entry point.
As a result, the TEE_UnmakCancellation() should not be called at the end of
TA_OpenSessionEntryPoint(), but at the start of TA_InvokeCommandEntryPoint().

Signed-off-by: Cedric Auger <[email protected]>
Reviewed-by: Jerome Forissier <[email protected]>
  • Loading branch information
Cedric Auger committed Feb 21, 2024
1 parent 4b4caf7 commit 5e9ad63
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ta/os_test/ta_entry.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ TEE_Result TA_OpenSessionEntryPoint(uint32_t nParamTypes,
(void)pParams;
(void)ppSessionContext;
DMSG("TA_OpenSessionEntryPoint");
TEE_UnmaskCancellation();
return TEE_SUCCESS;
}

Expand All @@ -63,6 +62,7 @@ TEE_Result TA_InvokeCommandEntryPoint(void *pSessionContext,
TEE_Param pParams[4])
{
(void)pSessionContext;
TEE_UnmaskCancellation();

switch (nCommandID) {
case TA_OS_TEST_CMD_INIT:
Expand Down

0 comments on commit 5e9ad63

Please sign in to comment.