xtest: pkcs11_1021: skip CKM_RSA_PKCS test is not supported #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforissier
reviewed
Nov 26, 2024
There was a problem hiding this comment.
With s/append/happen/:
Reviewed-by: Jerome Forissier <[email protected]>
|
...and "s/is not supported/if not supported/" |
etienne-lms
force-pushed
the
pkcs11-1021
branch
from
f248a93 to
166550e
Compare
Skip CKM_RSA_PKCS test in pkcs11_1021 if the mechanism is not supported. This is likely to happen when OP-TEE core is built with CFG_CRYPTO_RSASSA_NA1 disabled as when built with MbedTLS as core crypto library. Signed-off-by: Etienne Carriere <[email protected]> Reviewed-by: Jerome Forissier <[email protected]>
etienne-lms
force-pushed
the
pkcs11-1021
branch
from
166550e to
2368688
Compare
|
Commit message fixed and review tag applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip CKM_RSA_PKCS test in pkcs11_1021 is the mechanism is not supported. This is likely to append when OP-TEE core is built with CFG_CRYPTO_RSASSA_NA1 disabled as when built with MbedTLS as core crypto library.