Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: add case 1041 for fTPM #766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions host/xtest/ftpm_ta.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
/* SPDX-License-Identifier: BSD-2-Clause */
/*
* Copyright (c) 2024 Linaro Limited
*
* The copyright in this software is being made available under the BSD License,
* included below. This software may be subject to other third party and
* contributor rights, including patent rights, and no such rights are granted
* under this license.
*
* Copyright (c) 2018 Microsoft Corporation
*
* All rights reserved.
*
* BSD License
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
* met:
*
* Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer.
*
* Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
* IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
* TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
* PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED
* TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
* LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole license text is not really welcome, but I suppose you prefer to have an exact copy of the header file from the fTPM TA tree?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the problem is that the license text isn't identical to the boilerplate at https://spdx.org/licenses/BSD-2-Clause.html since they have [1] at the top. We could perhaps keep [1] and drop the rest since the rest only differs by omitting the numbers if I'm not mistaken.

[1]:

 * The copyright in this software is being made available under the BSD License,
 * included below. This software may be subject to other third party and
 * contributor rights, including patent rights, and no such rights are granted
 * under this license.


#ifndef FTPM_TA_H
#define FTPM_TA_H

/* This UUID is generated with uuidgen */
#define TA_FTPM_UUID { 0xBC50D971, 0xD4C9, 0x42C4, \
{0x82, 0xCB, 0x34, 0x3F, 0xB7, 0xF3, 0x78, 0x96}}

/* The TAFs ID implemented in this TA */
#define TA_FTPM_SUBMIT_COMMAND (0)
#define TA_FTPM_EMULATE_PPI (1)

#endif /*FTPM_TA_H*/
31 changes: 31 additions & 0 deletions host/xtest/regression_1000.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <ta_arm_bti.h>
#include <ta_concurrent.h>
Expand All @@ -41,6 +42,7 @@
#include <utee_defines.h>
#include <util.h>

#include "ftpm_ta.h"
#include "xtest_helpers.h"
#include "xtest_test.h"
#include "xtest_uuid_helpers.h"
Expand Down Expand Up @@ -3361,3 +3363,32 @@ static void xtest_tee_test_1040(ADBG_Case_t *c)
}
ADBG_CASE_DEFINE(regression, 1040, xtest_tee_test_1040,
"Test panic in concurrent open/invoke/close session");

static void xtest_tee_test_1041(ADBG_Case_t *c)
{
const char fname[] = "/dev/tpm0";
TEE_Result res = TEEC_SUCCESS;
TEEC_Session sess = { };
uint32_t ret_orig = 0;
struct stat sb = { };

res = xtest_teec_open_session(&sess, &(const TEEC_UUID)TA_FTPM_UUID,
NULL, &ret_orig);
if (res == TEEC_ERROR_ITEM_NOT_FOUND) {
Do_ADBG_Log("skip test, fTPM TA not present");
return;
}
if (res != TEEC_ERROR_BUSY && ADBG_EXPECT_TEEC_SUCCESS(c, res))
TEEC_CloseSession(&sess);

if (!ADBG_EXPECT_COMPARE_SIGNED(c, stat(fname, &sb), ==, 0)) {
Do_ADBG_Log("stat(\"%s\"): %s", fname, strerror(errno));
if (res != TEEC_ERROR_BUSY)
Do_ADBG_Log("Perhaps fTPM hasn't finished probing");
return;
}

if (!ADBG_EXPECT_TRUE(c, S_ISCHR(sb.st_mode)))
Do_ADBG_Log("Expected \"%s\" to be a character device", fname);
}
ADBG_CASE_DEFINE(regression, 1041, xtest_tee_test_1041, "Test fTPM sanity");
Loading