Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: test saturation values for table order. #4144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix: test saturation values for table order. #4144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions opm/material/fluidmatrixinteractions/PiecewiseLinearTwoPhaseMaterialParams.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,7 @@ class PiecewiseLinearTwoPhaseMaterialParams : public EnsureFinalized
private:
void swapOrderIfPossibleThrowOtherwise_(ValueVector& swValues, ValueVector& values) const
{
// TODO: comparing saturation values to the actual values we sample from looks strange
// TODO: yet changing to swValues.back() breaks tests
if (swValues.front() > values.back()) {
if (swValues.front() > swValues.back()) {
// Reverting the order involves swapping which only works for non-consts.
// The const expr ensures we can create constant parameter views.
if constexpr (!std::is_const_v<typename ValueVector::value_type> && !std::is_const_v<ValueVector>) {
Expand Down