Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo - and test the automatic deployment to opm-python-documentat… #4147

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

lisajulia
Copy link
Contributor

…ion with this

@lisajulia lisajulia requested a review from atgeirr July 24, 2024 13:36
@lisajulia
Copy link
Contributor Author

jenkins build this please

@atgeirr
Copy link
Member

atgeirr commented Jul 24, 2024

I see this:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   151  100   109  100    42   1131    435 --:--:-- --:--:-- --:--:--  1572
{
  "message": "Bad credentials",
  "documentation_url": "https://docs.github.com/rest",
  "status": "401"
}

in the "Send dispatch..." section of the first check, yet it is classified as "Successful in 4s", does that make sense? Is it a false negative?

@lisajulia
Copy link
Contributor Author

lisajulia commented Jul 24, 2024

I see this:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   151  100   109  100    42   1131    435 --:--:-- --:--:-- --:--:--  1572
{
  "message": "Bad credentials",
  "documentation_url": "https://docs.github.com/rest",
  "status": "401"
}

in the "Send dispatch..." section of the first check, yet it is classified as "Successful in 4s", does that make sense? Is it a false negative?

Yes, and bad credentials seems like there is something wrong with the token we just added, that should rather be sth. like this: https://github.com/lisajulia/opm-common/actions/runs/10078073645/job/27862190617

@lisajulia
Copy link
Contributor Author

lisajulia commented Jul 25, 2024

@atgeirr: I think we had this before: If the github action is triggered from a fork, there are authentication problems, in this PR it ran through: #4151.
I have deactivated the trigger for PRs now in this commit, so now only if sth on master changes, opm-python-documentation will get notified.
So now this is ready :)

@lisajulia
Copy link
Contributor Author

jenkins build this please

@lisajulia lisajulia merged commit d075bc8 into OPM:master Jul 29, 2024
1 check passed
@lisajulia lisajulia deleted the feature/documentation-dispatch branch July 29, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants