Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle MAPAXES and MAPUNITS #4257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle MAPAXES and MAPUNITS #4257

wants to merge 1 commit into from
+158 −67

Conversation

daavid00
Copy link
Contributor

This allows to map the coordinates for the given MAPAXES and MAPUNITS when calling the Python methods in EGrid (e.g., xyz_from_ijk).
I saw this morning the branches for the coming release were created, it would be amazing if this could make it to the release.

@daavid00
Copy link
Contributor Author

jenkins build this please

@daavid00
Copy link
Contributor Author

jenkins build this please

bska
bska reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to include map handling in our coordinates, then I think there should be an explicit and separate member function for it. There are more uses for EGrid::getCellCorners() than just putting coordinates into a visualisation scene.

bska
bska reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want any MAPAXES-related changes to getCellCorners() at all. If you really want to include MAPAXES in that kind of request, then I want a separate member function, e.g., getCellCornersWithMapAxes() that does that job.

@daavid00 daavid00 force-pushed the mapaxes branch 2 times, most recently from 68c61ad to 35a7410 Compare October 14, 2024 13:03
@daavid00
Copy link
Contributor Author

I don't want any MAPAXES-related changes to getCellCorners() at all. If you really want to include MAPAXES in that kind of request, then I want a separate member function, e.g., getCellCornersWithMapAxes() that does that job.

Now this is done via getCellCornersWithMapAxes(), can a Jenkins be run or does this need further changes?

@daavid00
Copy link
Contributor Author

jenkins build this please

@daavid00
Copy link
Contributor Author

jenkins build this please

@daavid00 daavid00 force-pushed the mapaxes branch 2 times, most recently from b388a62 to ec86986 Compare October 16, 2024 12:37
@daavid00
Copy link
Contributor Author

jenkins build this please

@daavid00
Copy link
Contributor Author

daavid00 commented Nov 7, 2024

jenkins build this please

@daavid00
Copy link
Contributor Author

daavid00 commented Nov 7, 2024

I have rebased this PR and added a test, can this PR be merged @bska?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bska bska bska left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daavid00 @bska