Local Cartesian Index for level grids #765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blattms
reviewed
Sep 27, 2024
| } | ||
| /// Additional methods realted to LGRs. END |
opm/grid/cpgrid/CpGridData.hpp
Outdated
|
|
||
| // Only relevant for refined level grids. | ||
| /** @brief Map from global_cell_lgr to leaf index set. Only relevant for refined level grids. */ | ||
| std::unordered_map<int,int> globalCellLevel_to_leafIdx_; |
There was a problem hiding this comment.
This should not be a member of CpGridData. If people need then this is only for a short time. Then this should be setup outside of the grid..
Take a look at:
- grid/utility/cartesianToCompressed.cpp
- grid/utility/cartesianToCompressed.hpp
- grid/utility/compressedToCartesian.cpp
- grid/utility/compressedToCartesian.hpp
There was a problem hiding this comment.
It might be time to take another look to #687 too. Thanks for your feedback!
aritorto
force-pushed
the
cartesianMapperLevels
branch
from
f1f25d0
to
eab87ce
Compare
|
jenkins build this please |
aritorto
force-pushed
the
cartesianMapperLevels
branch
from
d300f54
to
15a05f4
Compare
|
jenkins build this please |
|
jenkins build this opm-simulators=5633 please |
1 similar comment
|
jenkins build this opm-simulators=5633 please |
|
Replace/improve by #766 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each level grid, a map is created from global cell values (from that level), to leaf index set.
To this aim, CartesianIndexMapper has been extended - due to local Cartesian Index for each LGR for CpGrid, therefore the specializations for all grids have been adapted too (CpGrid, PolyhedralGrid, and in a separately PR, AluGrid OPM/opm-simulators#5633).
Based on #762 (which has been merged)
Not relevant for the Reference Manual