Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to OpenVR 1.0.11, Support Multiple Vive Trackers #37

Merged
merged 5 commits into from
Dec 10, 2017
Merged

Conversation

gfrolov
Copy link

@gfrolov gfrolov commented Sep 12, 2017

This pull request updates the OSVR-Vive to the latest OpenVR 1.0.11 and also adds functionality to support multiple Vive trackers - #36

@rpavlik
Copy link
Member

rpavlik commented Sep 19, 2017

I suspect you left some commits out - I only see 1 commit that mostly looks like an OpenVR 1.10 update

@@ -145,6 +145,8 @@ namespace vive {
vr::Prop_DriverDirectModeSendsVsyncEvents_Bool,
DisplayDebugMode = vr::Prop_DisplayDebugMode_Bool,
GraphicsAdapterLuid = vr::Prop_GraphicsAdapterLuid_Uint64,
DriverProvidedChaperonePath =
vr::Prop_DriverProvidedChaperonePath_String,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this updated with the tool or manually? (Just wanted to make sure it was the tool so that it's complete)

Copy link
Author

@gfrolov gfrolov Sep 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, with a tool. There were not a lot of changes there

@gfrolov gfrolov changed the title Update to OpenVR 1.0.10, Support Multiple Vive Trackers, DisplayExtractor fix Update to OpenVR 1.0.10, Support Multiple Vive Trackers Dec 7, 2017
@DuFF14
Copy link
Member

DuFF14 commented Dec 8, 2017

Tested that multiple puck tracking is working fine when I build RelWithDebInfo. Server crashes when I start the server with a Release build of the plugin. Could be a dependency issue on my end?

@gfrolov
Copy link
Author

gfrolov commented Dec 8, 2017

The CMake is most likely linking against debug libraries if it cannot find Release type libraries. Since OSVR-Core is built with RelWithDebInfo, the CMake will choose debug instead.
I built the project in Release mode and confirmed that's the case for me as well.

@DuFF14
Copy link
Member

DuFF14 commented Dec 8, 2017

Yea, it was linking against the debug libraries. Release build works if I edit that manually. Code looks fine to me.

@gfrolov gfrolov changed the title Update to OpenVR 1.0.10, Support Multiple Vive Trackers Update to OpenVR 1.0.11, Support Multiple Vive Trackers Dec 8, 2017
@gfrolov gfrolov merged commit f70a570 into master Dec 10, 2017
@gfrolov gfrolov deleted the openvr110 branch December 10, 2017 18:20
This was referenced Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants