-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to OpenVR 1.0.11, Support Multiple Vive Trackers #37
Conversation
I suspect you left some commits out - I only see 1 commit that mostly looks like an OpenVR 1.10 update |
@@ -145,6 +145,8 @@ namespace vive { | |||
vr::Prop_DriverDirectModeSendsVsyncEvents_Bool, | |||
DisplayDebugMode = vr::Prop_DisplayDebugMode_Bool, | |||
GraphicsAdapterLuid = vr::Prop_GraphicsAdapterLuid_Uint64, | |||
DriverProvidedChaperonePath = | |||
vr::Prop_DriverProvidedChaperonePath_String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this updated with the tool or manually? (Just wanted to make sure it was the tool so that it's complete)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, with a tool. There were not a lot of changes there
Tested that multiple puck tracking is working fine when I build RelWithDebInfo. Server crashes when I start the server with a Release build of the plugin. Could be a dependency issue on my end? |
The CMake is most likely linking against debug libraries if it cannot find Release type libraries. Since OSVR-Core is built with RelWithDebInfo, the CMake will choose debug instead. |
Yea, it was linking against the debug libraries. Release build works if I edit that manually. Code looks fine to me. |
This pull request updates the OSVR-Vive to the latest OpenVR 1.0.11 and also adds functionality to support multiple Vive trackers - #36