-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/519 extra line break added to file link #530
base: master
Are you sure you want to change the base?
Bugfix/519 extra line break added to file link #530
Conversation
Thanks for the PR. Can this be made as an setting, which is default Off. Since many people would be used to the line break by now. |
I can work on that. |
@ShootingKing-AM I've added a toggle to the settings for prepending the line break. I've also added some code to main.js that when loading settings, will merge the default settings with settings saved to data.json. I noticed that prior behavior lead to newly added default settings not being added to the settings menu unless deleted your data.json. Now that's fixed. |
@ShootingKing-AM Any chance of merging this PR? |
@mattcoleanderson this is blocked by #447 :( |
Thanks for fixing this, @mattcoleanderson. If it's not too much to ask, could you tell me how I'd overwrite the current plugin files (installed inside Obsidian) with the changes you've made? |
closes #519
@ShootingKing-AM I've tested the change manually, however I ran into issues running the python test scripts. So I wouldn't be surprised if the e2e test fails initially.