Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SyncMode option to PebbleExtraOptions #376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add SyncMode option to PebbleExtraOptions #376

wants to merge 2 commits into from
+2 −1

Conversation

magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Nov 19, 2024 •
edited
Loading

Resolves NIT-2952

@cla-bot cla-bot bot added the s CLA signed label Nov 19, 2024
@magicxyyz magicxyyz mentioned this pull request Nov 19, 2024
Open
@magicxyyz magicxyyz marked this pull request as ready for review November 19, 2024 19:43
tsahee
tsahee approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee
Copy link
Contributor

tsahee commented Nov 28, 2024

Need to spend some time thinking what should be default for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsahee tsahee tsahee approved these changes

@diegoximenes diegoximenes diegoximenes approved these changes

@amsanghi amsanghi Awaiting requested review from amsanghi

Assignees
No one assigned
Labels
s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicxyyz @tsahee @diegoximenes