Filter transaction #377
Open
Filter transaction #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshvanahalli
requested review from
PlasmaPower,
joshuacolvin0,
eljobe and
amsanghi
eljobe
requested changes
Nov 25, 2024
eljobe
reviewed
Nov 26, 2024
core/state/statedb.go
Outdated
| type arbFiltered int | ||
|
|
||
| const ( | ||
| txFiltered arbFiltered = 1 + iota |
There was a problem hiding this comment.
I think there should be another value in the enum for the zero value.
Maybe unfiltered or notFiltered
eljobe
approved these changes
Nov 26, 2024
| type arbFiltered int | ||
|
|
||
| const ( | ||
| unFiltered arbFiltered = iota |
There was a problem hiding this comment.
Sorry to be so picky, but since unfiltered is a single word in English. I'd either use unfiltered or notFiltered here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables filtering of malicious transactions and blocks via a
stateDBobjectCorresponding Nitro PR- OffchainLabs/nitro#2807
Part of NIT-2848