Skip to content

Commit

Permalink
Add comment about deploying factories to L2
Browse files Browse the repository at this point in the history
  • Loading branch information
gvladika committed Sep 11, 2023
1 parent 45ecd6b commit 116d651
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/rollup/RollupCreator.sol
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,10 @@ contract RollupCreator is Ownable {
* @param _validators The list of validator addresses, not used when set to empty list
* @param _nativeToken Address of the custom fee token used by rollup. If rollup is ETH-based address(0) should be provided
* @param _deployFactoriesToL2 Whether to deploy L2 factories using retryable tickets. If true, retryables need to be paid for in native currency.
* Deploying factories via retyrable tickets at rollup creation time is the most reliable method to do it since it
* doesn't require paying the L1 gas. If deployment is instead done directly via L2 TX, there is a risk of gas price
* spike which results in burned nonce 0. That would mean we permanently lost capability to deploy deterministic
* factory at expected canonical address.
* @return The address of the newly created rollup
*/
function createRollup(
Expand Down

0 comments on commit 116d651

Please sign in to comment.