Use transient storage in Outbox and Bridge #260
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
godzillaba
reviewed
Oct 21, 2024
gzeoneth
requested changes
Oct 25, 2024
gzeoneth
reviewed
Oct 31, 2024
src/bridge/AbsOutbox.sol
Outdated
Comment on lines
49
to
51
| /// @dev Due to how arb governance works, it is not possible to wipe out the content of these | ||
| /// 4 storage slots during the upgrade. So after deprecation values in these slots will | ||
| /// stay "dirty" with default values, but slots will not be used or accessible in any way. |
There was a problem hiding this comment.
let's remove these, keeping them dirty is simply a design choice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate transient storage for:
Some plugins are temporary disabled as they're not working with the Solidity 0.8.28 due to 'transient' keyword