chore: bold deploy script improvements #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6948823.
gzeoneth
changed the title
yahgwai
reviewed
Nov 21, 2024
| @@ -315,32 +369,44 @@ async function checkOldRollup(params: VerificationParams) { | |||
| ) { | |||
| throw new Error('Old rollup was not upgraded') | |||
| } | |||
|
|
|||
| // using the reader factory here for typing | |||
| const rollupReaderContract = RollupReader__factory.connect(config.contracts.rollup, l1Rpc) | |||
There was a problem hiding this comment.
why does this rollupreader still exist? i thought we were getting rid of it
There was a problem hiding this comment.
it is in the #266 PR, I don't want to mix the contract change with this PR but that will be merged after this one
yahgwai
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various changes to the bold deployment script, no contract change.
ROLLUP_ADDRESSfor testnode integrationANVILFORKflag for fork testingcurrentInboxCountis used for validationThis PR also changed the imported nitro-contract version, but will be deprecated and removed in #266