Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Hardhat version #53

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Bump Hardhat version #53

merged 4 commits into from
Sep 11, 2023

Conversation

gvladika
Copy link
Contributor

@gvladika gvladika commented Sep 1, 2023

Change package version:

  • node version 18 in CI
  • Hardhat 2.17.2 (latest)

Bump of solidity-coverage required as well due to backward incompatiblity. Latest version solidity-coverage still failed:

ParserError: Expected ',' but got ';'
   --> src/mocks/Simple.sol:205:40:
    |
205 |         (c_83b71b6f(0x137081c2a34587c9); /* statement */
    |                                        ^


Error in plugin solidity-coverage: HardhatError: HH600: Compilation failed

Solution was to remove parenthesis around low level call in Simple.sol. And then use hardhat-ignore-warnings to silence 'unused return call value' compiler warning.

Also bumped hardhat-deploy and hardhat-gas-reporteralthough it was not neccessary.

@cla-bot cla-bot bot added the s label Sep 1, 2023
Copy link
Member

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think we can rebase this on main

@gzeoneth gzeoneth changed the base branch from develop to main September 11, 2023 08:16
@gzeoneth
Copy link
Member

might need to force merge to main

Copy link
Collaborator

@hkalodner hkalodner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkalodner hkalodner merged commit a1cdec7 into main Sep 11, 2023
1 of 2 checks passed
@hkalodner hkalodner deleted the bump-hardhat branch September 11, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants