Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add updateRollupAddress to bridge #54

Closed
wants to merge 3 commits into from
Closed

Add updateRollupAddress to bridge #54

wants to merge 3 commits into from

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Sep 1, 2023 •
edited
Loading

@cla-bot cla-bot bot added the s label Sep 1, 2023
@amsanghi amsanghi changed the base branch from main to develop September 1, 2023 09:58
@amsanghi amsanghi changed the title Rollup update Add updateRollupAddress to bridge Sep 1, 2023
@amsanghi amsanghi marked this pull request as ready for review September 1, 2023 10:04
@gzeoneth
Copy link
Member

gzeoneth commented Sep 1, 2023

I think it is better to base this PR on #48

@gzeoneth gzeoneth changed the base branch from develop to bold-withdraw-when-paused September 1, 2023 11:35
yahgwai
yahgwai reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@yahgwai yahgwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were made in the bold repo - eg https://github.com/OffchainLabs/bold/blob/main/contracts/src/bridge/Bridge.sol#L67

So i think these changes will get ported over from bold eventually? @gzeoneth

@gzeoneth gzeoneth mentioned this pull request Oct 24, 2023
Merged
2 tasks
@gzeoneth gzeoneth closed this Oct 27, 2023
@gzeoneth
Copy link
Member

#83

@gzeoneth gzeoneth deleted the rollup_update branch October 27, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahgwai yahgwai yahgwai left review comments

@PlasmaPower PlasmaPower Awaiting requested review from PlasmaPower

@gzeoneth gzeoneth Awaiting requested review from gzeoneth

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amsanghi @gzeoneth @yahgwai