Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "Add sha256 preimage support" #69

Merged
merged 1 commit into from
Oct 4, 2023
Merged

revert: "Add sha256 preimage support" #69

merged 1 commit into from
Oct 4, 2023

Conversation

gzeoneth
Copy link
Member

@gzeoneth gzeoneth commented Oct 4, 2023 •
edited
Loading

Reverts #50 to unblock release before further review

@cla-bot cla-bot bot added the s label Oct 4, 2023
@gzeoneth gzeoneth mentioned this pull request Oct 4, 2023
Merged
hkalodner
hkalodner approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@hkalodner hkalodner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gzeoneth gzeoneth merged commit fdf7c4c into develop Oct 4, 2023
2 checks passed
@gzeoneth gzeoneth deleted the revert-50-sha256-preimage branch October 4, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkalodner hkalodner hkalodner approved these changes

@yahgwai yahgwai Awaiting requested review from yahgwai

@PlasmaPower PlasmaPower Awaiting requested review from PlasmaPower

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gzeoneth @hkalodner