-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeboost Bulk BlockMetadata API #2754
base: add-timeboosted-broadcastfeedmessage
Are you sure you want to change the base?
Timeboost Bulk BlockMetadata API #2754
Conversation
I'm afraid I cannot realistically review this with everything going on with BoLD. Sorry. Removing myself as a reviewer for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a question about hexutil.Uint64
use instead of rpc.BlockNumber
and some nitpicks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one comment about input validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! just one suggestion for sanity checks in SetReorgEventsNotifier
, sorry for missing that before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces an RPC method to the
arb
namespace calledarb_getRawBlockMetadata
, which takes a range and returns an array ofNumberAndBlockMetadata
struct which contains theblockNumber
andblockMetadata
in hex encoding, for all the blocks in the range that the node hasblockMetadata
for.To enhance performance, the api uses LRU cache to store the newly fetched blockMetadata from local DB, this is enabled by default and can be set using
--execution.block-metadata-api-cache-size
to a positive value.Pulls in Geth PR- OffchainLabs/go-ethereum#372
Resolves NIT-2837