Strictness Checks

Bringing over the stricter config from NBTify and my other projects :)

package.json

@@ -12,10 +12,10 @@
     "@stedit/num-text": "^1.0.1"
   },
   "devDependencies": {
-    "@types/prismjs": "^1.26.0",
-    "better-typescript": "^0.1.2",
-    "new-javascript": "^0.3.5",
-    "typescript": "^5.1.6",
-    "vite": "^4.4.2"
+    "@types/prismjs": "^1.26.1",
+    "better-typescript": "^0.1.6",
+    "new-javascript": "^0.3.6",
+    "typescript": "^5.2.2",
+    "vite": "^4.4.9"
   }
 }

public/service-worker.js

@@ -4,7 +4,7 @@
 var self = /** @type { ServiceWorkerGlobalScope } */ (/** @type { unknown } */ (globalThis));
 
 const NAME = "Smart Text Editor";
-const VERSION = "v4.27.3";
+const VERSION = "v4.27.4";
 const CACHE_NAME = /** @type { const } */ (`${NAME} ${VERSION}`);
 
 const IS_MACOS_DEVICE = (/(macOS|Mac)/i.test(navigator.userAgentData?.platform ?? navigator.platform) && navigator.standalone === undefined);

src/Card.ts

@@ -28,10 +28,10 @@ export class Card extends HTMLElement {
       if (!event.shiftKey){
         if (document.activeElement != navigable[navigable.length - 1]) return;
         event.preventDefault();
-        navigable[0].focus();
+        navigable[0]?.focus();
       } else if (document.activeElement == navigable[0]){
         event.preventDefault();
-        navigable[navigable.length - 1].focus();
+        navigable[navigable.length - 1]?.focus();
       }
     });
     this.type = this.getAttribute("data-type");
@@ -76,7 +76,7 @@ export class Card extends HTMLElement {
         if (card.type != "dialog" && card.type != this.type) return;
         card.close();
         if (!card.matches(".minimize")) return;
-        const transitionDuration = parseInt(`${Number(getElementStyle({ element: card, property: "transition-duration" }).split(",")[0].replace(/s/g,"")) * 1000}`);
+        const transitionDuration = parseInt(`${Number(getElementStyle({ element: card, property: "transition-duration" }).split(",")[0]!.replace(/s/g,"")) * 1000}`);
         window.setTimeout(() => card.minimize(),transitionDuration);
       });
     }
@@ -98,7 +98,7 @@ export class Card extends HTMLElement {
         STE.dialogPrevious = document.activeElement as Card;
       }
       document.querySelectorAll<MenuDropElement>("menu-drop[data-open]").forEach(menu => menu.close());
-      const transitionDuration = parseInt(`${Number(getElementStyle({ element: this, property: "transition-duration" }).split(",")[0].replace(/s/g,"")) * 500}`);
+      const transitionDuration = parseInt(`${Number(getElementStyle({ element: this, property: "transition-duration" }).split(",")[0]!.replace(/s/g,"")) * 500}`);
       window.setTimeout(() => {
         if (document.activeElement instanceof HTMLElement) document.activeElement.blur();
         if (previous) this.querySelector<HTMLElement>(`[data-card-previous="${previous.id}"]`)!.focus();
@@ -115,7 +115,7 @@ export class Card extends HTMLElement {
 
     this.setAttribute("data-minimize-change",changeIdentifier);
     workspace_tabs.setAttribute("data-minimize-change",changeIdentifier);
-    const transitionDuration = parseInt(`${Number(getElementStyle({ element: this, property: "transition-duration" }).split(",")[0].replace(/s/g,"")) * 1000}`);
+    const transitionDuration = parseInt(`${Number(getElementStyle({ element: this, property: "transition-duration" }).split(",")[0]!.replace(/s/g,"")) * 1000}`);
     if (!this.matches(".minimize")){
       this.classList.add("minimize");
       if (this.controls === undefined) return;
@@ -147,7 +147,7 @@ export class Card extends HTMLElement {
   close(): void {
     this.classList.remove("active");
     if (this.matches(".minimize")){
-      const transitionDuration = parseInt(`${Number(getElementStyle({ element: this, property: "transition-duration" }).split(",")[0].replace(/s/g,"")) * 1000}`);
+      const transitionDuration = parseInt(`${Number(getElementStyle({ element: this, property: "transition-duration" }).split(",")[0]!.replace(/s/g,"")) * 1000}`);
       window.setTimeout(() => this.minimize(),transitionDuration);
     }
     if (this.type == "dialog"){
@@ -178,7 +178,7 @@ export class Card extends HTMLElement {
     if (!STE.activeDialog || event.key != "Tab" || document.activeElement != document.body) return;
     const navigable = Card.#getNavigableElements({ container: STE.activeDialog, scope: true });
     event.preventDefault();
-    navigable[((!event.shiftKey) ? 0 : navigable.length - 1)].focus();
+    navigable[((!event.shiftKey) ? 0 : navigable.length - 1)]?.focus();
   }
 }
 

src/Editor.ts

@@ -27,15 +27,15 @@ export class Editor extends NumTextElement {
   */
   static open(identifier: string, options: EditorOpenOptions = {}): void {
     const editor = this.#editors[identifier];
-    editor.open(options);
+    editor?.open(options);
   }
 
   /**
    * Closes an Editor from a given identifier.
   */
   static async close(identifier: string): Promise<void> {
     const editor = this.#editors[identifier];
-    await editor.close();
+    await editor?.close();
   }
 
   /**
@@ -45,6 +45,9 @@ export class Editor extends NumTextElement {
   */
   static rename(identifier: string, rename?: string): void {
     const editor = this.#editors[identifier];
+    if (editor === undefined){
+      throw new Error(`Failed to rename editor '${identifier}', it may not exist`);
+    }
     const currentName = editor.#name;
 
     if (!rename){
@@ -62,12 +65,12 @@ export class Editor extends NumTextElement {
    * 
    * If the active Editor is the first one in the Workspace, it will wrap around to give the last Editor in the Workspace.
   */
-  static getPrevious(identifier: string, wrap: boolean = true): string | null {
+  static getPrevious(identifier: string, _wrap: boolean = true): string | null {
     const { tab } = STE.query(identifier);
     if (tab === null) return tab;
     const editorTabs = [...workspace_tabs.querySelectorAll(".tab:not([data-editor-change])")];
     const previousTab = editorTabs[(editorTabs.indexOf(tab) || editorTabs.length) - 1];
-    const previousEditor = previousTab.getAttribute("data-editor-identifier");
+    const previousEditor = previousTab?.getAttribute("data-editor-identifier") ?? null;
     return previousEditor;
   }
 
@@ -76,12 +79,12 @@ export class Editor extends NumTextElement {
    * 
    * If the active Editor is the last one in the Workspace, it will wrap around to give the first Editor in the Workspace.
   */
-  static getNext(identifier: string, wrap: boolean = true): string | null {
+  static getNext(identifier: string, _wrap: boolean = true): string | null {
     const { tab } = STE.query(identifier);
     if (tab === null) return tab;
     const editorTabs = [...workspace_tabs.querySelectorAll(".tab:not([data-editor-change])")];
     const nextTab = editorTabs[(editorTabs.indexOf(tab) !== editorTabs.length - 1) ? editorTabs.indexOf(tab) + 1 : 0];
-    const nextEditor = nextTab.getAttribute("data-editor-identifier");
+    const nextEditor = nextTab?.getAttribute("data-editor-identifier") ?? null;
     return nextEditor;
   }
 
@@ -136,7 +139,7 @@ export class Editor extends NumTextElement {
     const changeIdentifier = Math.random().toString();
 
     document.body.setAttribute("data-editor-change",changeIdentifier);
-    const transitionDuration = parseInt(`${Number(getElementStyle({ element: workspace_tabs, property: "transition-duration" }).split(",")[0].replace(/s/g,"")) * 1000}`);
+    const transitionDuration = parseInt(`${Number(getElementStyle({ element: workspace_tabs, property: "transition-duration" }).split(",")[0]!.replace(/s/g,"")) * 1000}`);
 
     this.tab.classList.add("tab");
     this.tab.setAttribute("data-editor-identifier",this.identifier);
@@ -364,7 +367,7 @@ export class Editor extends NumTextElement {
       }
     }
 
-    const transitionDuration = (document.body.hasAttribute("data-editor-change")) ? parseInt(`${Number(getElementStyle({ element: workspace_tabs, property: "transition-duration" }).split(",")[0].replace(/s/g,"")) * 1000}`) : 0;
+    const transitionDuration = (document.body.hasAttribute("data-editor-change")) ? parseInt(`${Number(getElementStyle({ element: workspace_tabs, property: "transition-duration" }).split(",")[0]!.replace(/s/g,"")) * 1000}`) : 0;
 
     if (this.tab === editorTabs[0] && editorTabs.length === 1){
       STE.activeEditor = null;
@@ -381,11 +384,11 @@ export class Editor extends NumTextElement {
       Editor.open(identifier);
     }
     if (this.tab === editorTabs[editorTabs.length - 1] && this.tab !== editorTabs[0] && this.tab.classList.contains("active")){
-      const identifier = editorTabs[editorTabs.length - 2].getAttribute("data-editor-identifier")!;
+      const identifier = editorTabs[editorTabs.length - 2]!.getAttribute("data-editor-identifier")!;
       Editor.open(identifier);
     }
     if (this.tab !== editorTabs[0] && this.tab.classList.contains("active")){
-      const identifier = editorTabs[editorTabs.indexOf(this.tab) + 1].getAttribute("data-editor-identifier")!;
+      const identifier = editorTabs[editorTabs.indexOf(this.tab) + 1]!.getAttribute("data-editor-identifier")!;
       Editor.open(identifier);
     }
 

src/Tools.ts

@@ -24,7 +24,7 @@ export class Tools {
     },
 
     clear(): void {
-      [replacer_find.value,replacer_replace.value] = "";
+      [replacer_find.value,replacer_replace.value] = ["",""];
     }
   }
 

src/Workspace.ts

@@ -39,7 +39,7 @@ export function setView(type: View, { force = false }: SetViewOptions = {}): voi
   if ((STE.orientationChange && !force) || STE.scalingChange) return;
   const changeIdentifier = Math.random().toString();
   document.body.setAttribute("data-view-change",changeIdentifier);
-  const transitionDuration = parseInt(`${Number(getElementStyle({ element: workspace, property: "transition-duration" }).split(",")[0].replace(/s/g,"")) * 1000}`);
+  const transitionDuration = parseInt(`${Number(getElementStyle({ element: workspace, property: "transition-duration" }).split(",")[0]!.replace(/s/g,"")) * 1000}`);
   document.body.classList.remove(STE.view);
   document.body.setAttribute("data-view",type);
   document.body.classList.add(STE.view);
@@ -62,7 +62,7 @@ export type Orientation = "horizontal" | "vertical";
 export function setOrientation(orientation?: Orientation): void {
   if (STE.orientationChange || STE.scalingChange) return;
   document.body.setAttribute("data-orientation-change","");
-  const param = (orientation), transitionDuration = ((STE.view != "split") ? 0 : parseInt(`${Number(getElementStyle({ element: workspace, property: "transition-duration" }).split(",")[0].replace(/s/g,"")) * 1000}`));
+  const param = (orientation), transitionDuration = ((STE.view != "split") ? 0 : parseInt(`${Number(getElementStyle({ element: workspace, property: "transition-duration" }).split(",")[0]!.replace(/s/g,"")) * 1000}`));
   if (!param && STE.view == "split") setView("code",{ force: true });
   if (!param && STE.orientation == "horizontal") orientation = "vertical";
   if (!param && STE.orientation == "vertical") orientation = "horizontal";
@@ -197,8 +197,8 @@ export async function saveFile(extension?: string): Promise<void> {
       });
       if (!handle) return;
       STE.fileHandles[identifier] = handle;
-    } else handle = STE.fileHandles[identifier];
-    const stream = await STE.fileHandles[identifier].createWritable().catch(error => {
+    } else handle = STE.fileHandles[identifier]!;
+    const stream = await STE.fileHandles[identifier]?.createWritable().catch(error => {
       alert(`"${STE.query().getName()}" could not be saved.`);
       if (error.toString().toLowerCase().includes("not allowed")) return;
     });
@@ -276,8 +276,8 @@ export function setScaling(event: MouseEvent | TouchEvent): void {
   };
   const touchEvent = (STE.environment.touchDevice && event instanceof TouchEvent);
 
-  if (STE.orientation == "horizontal") scalingOffset = (!touchEvent) ? (event as MouseEvent).pageX : (event as TouchEvent).touches[0].pageX;
-  if (STE.orientation == "vertical") scalingOffset = (!touchEvent) ? (event as MouseEvent).pageY - header.offsetHeight : (event as TouchEvent).touches[0].pageY - header.offsetHeight;
+  if (STE.orientation == "horizontal") scalingOffset = (!touchEvent) ? (event as MouseEvent).pageX : (event as TouchEvent).touches[0]!.pageX;
+  if (STE.orientation == "vertical") scalingOffset = (!touchEvent) ? (event as MouseEvent).pageY - header.offsetHeight : (event as TouchEvent).touches[0]!.pageY - header.offsetHeight;
   if (scalingOffset < scalingRange.minimum) scalingOffset = scalingRange.minimum;
   if (scalingOffset > scalingRange.maximum) scalingOffset = scalingRange.maximum;
   document.body.setAttribute("data-scaling-active","");

src/app.ts

@@ -90,7 +90,7 @@ window.addEventListener("beforeinstallprompt",event => {
   event.preventDefault();
   STE.installPrompt = event;
   document.documentElement.classList.add("install-prompt-available");
-  theme_button.childNodes[0].textContent = "Theme";
+  theme_button.childNodes[0]!.textContent = "Theme";
 });
 
 window.addEventListener("beforeunload",event => {

src/dom.ts

@@ -25,7 +25,7 @@ export function applyEditingBehavior(element: HTMLInputElement | NumTextElement)
 
   (element as HTMLElement).addEventListener("drop",event => {
     if (event.dataTransfer === null) return;
-    if ([...event.dataTransfer.items][0].kind === "file") return;
+    if ([...event.dataTransfer.items][0]?.kind === "file") return;
     event.stopPropagation();
     for (const menu of document.querySelectorAll<MenuDropElement>("menu-drop[data-open]")){
       menu.close();
@@ -72,7 +72,7 @@ export async function showInstallPrompt(): Promise<void> {
   const result = await STE.installPrompt.userChoice;
   if (result.outcome !== "accepted") return;
   document.documentElement.classList.remove("install-prompt-available");
-  theme_button.childNodes[0].textContent = "Customize Theme";
+  theme_button.childNodes[0]!.textContent = "Customize Theme";
 }
 
 /**

tsconfig.json

@@ -2,10 +2,9 @@
   "compilerOptions": {
     "allowJs": true,
     "checkJs": true,
-    "module": "ESNext",
-    "moduleResolution": "NodeNext",
-    "isolatedModules": true,
+    "module": "NodeNext",
     "target": "ESNext",
+    "isolatedModules": true,
     "types": [
       "@stedit/menu-drop",
       "@stedit/num-text",
@@ -14,7 +13,12 @@
     "noEmit": true,
     "skipLibCheck": true,
     "strict": true,
-    "noImplicitOverride": true
+    "noImplicitOverride": true,
+    "noPropertyAccessFromIndexSignature": true,
+    "noUncheckedIndexedAccess": true,
+    "allowUnreachableCode": false,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true
   },
   "exclude": [
     "./dist"