Add language key to anonymous reports
#11004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, a better way of getting the user's country would be using the native Geolocation API but I'm sure a lot of people wouldn't be happy with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #11003 - localized pages sometimes renders different content based on language/country. This PR adds a
languagekey to the anonymous reports so maintainers can test if it is a localization-related issue. I will also make a PR to the API repo if this gets accepted to grab the reporters country, and place the two pieces of data in the GitHub issues.Granted, these requests are supposed to be anonymous in nature, but I think we can do this as the bare-minimum to help maintainers find the issue faster, rather than parsing the URL paths. Let me know what you think.