Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix badges #11419

Merged
merged 1 commit into from
Feb 25, 2024
Merged

docs: fix badges #11419

merged 1 commit into from
Feb 25, 2024

Conversation

okay-head
Copy link
Contributor

@okay-head okay-head commented Feb 1, 2024

The badges render with a weird blue underline b/w them. This commit fixes that.

Issue:
image

Fix:
image

Fixed this issue for all the badges in the readme

The badges render with a weird blue underline b/w them.
This commit fixes that.
@okay-head
Copy link
Contributor Author

I know, sounds petty. But I've had enough trying to fix this in my own readmes. Now everywhere I see this rendering mismatch, I want to fix it.
It's possibly a result of the way line-endings or whitespaces are handled differently in gh flavored markdown.

@obfuscated-loop
Copy link
Collaborator

obfuscated-loop commented Feb 4, 2024

I know, sounds petty. But I've had enough trying to fix this in my own readmes. Now everywhere I see this rendering mismatch, I want to fix it.

I noticed this behaviour after it was implemented and was trying to fix it myself! Great job on finding the solution, it was oddly triggering me and I couldn't understand why it was doing it. I thought it was to do with some kind of default padding being applied to the anchor tags.

Great work again 👍 and your comment made me laugh.

@okay-head
Copy link
Contributor Author

Great work again 👍 and your comment made me laugh.

Thanks Jay! You can't unsee it once you've seen it lol.

And yes I've made the fix for all the badges in the readme. I'll mention that as well

@OhMyGuus OhMyGuus merged commit c619cc1 into OhMyGuus:master Feb 25, 2024
1 check passed
@OhMyGuus
Copy link
Owner

Haha good fix 👍

@okay-head okay-head deleted the okay-head-patch-1 branch March 1, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants