Proxied documents are no longer hardcoded to the "query" operation type. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegIlyenko
reviewed
Jun 28, 2018
| case h :: Nil => (h, Some("Delegated" + h)) | ||
| case x => throw new IllegalStateException(s"Query contains operations [${x.mkString(", ")}].") | ||
| } | ||
| val queryOp = ast.OperationDefinition(operationType = ot, name = n, variables = varDefs, selections = updatedFields) |
There was a problem hiding this comment.
I think you can replace hardcoded ast.OperationType.Query with something like this:
c.query.operationType(c.ctx.operationName) getOrElse
throw new IllegalStateException(s"Can't find operation type")You need to consider the operationName since it defines which operation must be executed if multiple operations are defined in the query.
Otherwise it looks good to me 👍 In future we need to think of a way how we can detach these 2. For example, in case I'm doing a mutation, but the delegate one of the nested fields. in this case delegated query type is Query even though original query is a Mutation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.