Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark members as non-public and move public AuthenticationError #163

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Mark members as non-public and move public AuthenticationError #163

merged 1 commit into from
Oct 27, 2024

Conversation

elliot-100
Copy link
Collaborator

@elliot-100 elliot-100 commented Oct 22, 2024 •
edited
Loading

As per issue #162, this PR marks these members as non-public, as they are not for end-user use:

spond.spond.Spond.chat_url -> spond.spond.Spond._chat_url
spond.spond.Spond.auth -> spond.spond.Spond._auth
spond.spond.Spond.login_chat() -> spond.spond.Spond._login_chat()

and moves this, as it should be public, but is currently in a module that only exists to hold the non-public _SpondBase class:

spond.base.AuthenticationError -> spond.AuthenticationError

@elliot-100
Mark spond.spond.Spond.chat_url, ...Spond.auth, `...Spond.login_c…
eeb748e 
…hat()` as non-public; move `spond.base.AuthenticationError` -> `spond.AuthenticationError`

Mark `spond.spond.Spond.chat_url`, `...Spond.auth`, `...Spond.login_chat()` as non-public
@elliot-100 elliot-100 marked this pull request as draft October 22, 2024 13:33
@elliot-100 elliot-100 force-pushed the 162-propose-marking-members-as-non-public-and-moving-public-authenticationerror branch from 7b52a63 to eeb748e Compare October 22, 2024 13:33
@elliot-100 elliot-100 changed the title 162 propose marking members as non public and moving public authenticationerror Mark members as non-public and move public AuthenticationError Oct 22, 2024
@elliot-100 elliot-100 marked this pull request as ready for review October 22, 2024 13:34
@elliot-100 elliot-100 linked an issue Oct 22, 2024 that may be closed by this pull request
Propose marking members as non-public and moving public AuthenticationError #162
Closed
@elliot-100 elliot-100 self-assigned this Oct 23, 2024
@elliot-100 elliot-100 merged commit 0c55161 into Olen:main Oct 27, 2024
5 checks passed
@elliot-100 elliot-100 deleted the 162-propose-marking-members-as-non-public-and-moving-public-authenticationerror branch October 27, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elliot-100 elliot-100

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propose marking members as non-public and moving public AuthenticationError
1 participant
@elliot-100