fix lint & simulation issues

.github/workflows/lint.yml

@@ -11,7 +11,7 @@ on:
       - '**.go'
 
 env:
-  GO_VERSION: '1.20.0'
+  GO_VERSION: '1.21.0'
 
 permissions:
   contents: read
@@ -26,10 +26,10 @@ jobs:
     name: lint
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/setup-go@v3
+      - uses: actions/setup-go@v4
         with:
           go-version: ${{env.GO_VERSION}}
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:

x/onft/client/cli/tx.go

@@ -1,5 +1,3 @@
-//nolint: goconst
-
 package cli
 
 import (

x/onft/module.go

@@ -47,7 +47,7 @@ func (AppModuleBasic) DefaultGenesis(cdc codec.JSONCodec) json.RawMessage {
 	return cdc.MustMarshalJSON(DefaultGenesisState())
 }
 
-func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, config client.TxEncodingConfig, bz json.RawMessage) error {
+func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingConfig, bz json.RawMessage) error {
 	var data types.GenesisState
 	if err := cdc.UnmarshalJSON(bz, &data); err != nil {
 		return fmt.Errorf("failed to unmarshal %s genesis state: %w", types.ModuleName, err)
@@ -56,10 +56,6 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, config client.TxEncod
 	return types.ValidateGenesis(data)
 }
 
-func (AppModuleBasic) RegisterGRPCRoutes(clientCtx client.Context, mux *runtime.ServeMux) {
-	types.RegisterQueryHandlerClient(context.Background(), mux, types.NewQueryClient(clientCtx))
-}
-
 func (AppModuleBasic) GetTxCmd() *cobra.Command {
 	return cli.NewTxCmd()
 }
@@ -100,7 +96,7 @@ func NewAppModule(cdc codec.Codec, keeper keeper.Keeper, accountKeeper types.Acc
 
 func (AppModule) Name() string { return types.ModuleName }
 
-func (am AppModule) RegisterInvariants(ir sdk.InvariantRegistry) {
+func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {
 }
 
 func (AppModule) QuerierRoute() string { return types.RouterKey }
@@ -158,8 +154,7 @@ func (am AppModule) RegisterStoreDecoder(sdr sdk.StoreDecoderRegistry) {
 	sdr[types.StoreKey] = simulation.NewDecodeStore(am.cdc)
 }
 
-// ProposalContents doesn't return any content functions for governance proposals.
-func (AppModule) ProposalContents(simState module.SimulationState) []simtypes.WeightedProposalContent {
+func (am AppModule) ProposalContents(_ module.SimulationState) []simtypes.WeightedProposalMsg {
 	return nil
 }
 

x/onft/simulation/operations.go

@@ -431,38 +431,24 @@ func SimulateMsgUpdateDenom(k keeper.Keeper, ak types.AccountKeeper, bk types.Ba
 }
 
 func getRandomNFTFromOwner(ctx sdk.Context, k keeper.Keeper, r *rand.Rand) (address sdk.AccAddress, denomID, nftID string) {
-	owners := k.GetOwners(ctx)
-
-	ownersLen := len(owners)
-	if ownersLen == 0 {
+	denom, err := getRandomDenom(ctx, k, r)
+	if err != nil {
 		return nil, "", ""
 	}
-
-	// get random owner
-	i := r.Intn(ownersLen)
-	owner := owners[i]
-
-	idCollectionsLen := len(owner.IDCollections)
-	if idCollectionsLen == 0 {
+	onfts, err := k.GetONFTs(ctx, denom.Id)
+	if err != nil {
 		return nil, "", ""
 	}
-
-	// get random collection from owner's balance
-	i = r.Intn(idCollectionsLen)
-	idCollection := owner.IDCollections[i] // nfts IDs
-	denomID = idCollection.DenomId
-
-	idsLen := len(idCollection.OnftIds)
-	if idsLen == 0 {
+	nftsLen := len(onfts)
+	if nftsLen == 0 {
 		return nil, "", ""
 	}
 
-	// get random nft from collection
-	i = r.Intn(idsLen)
-	nftID = idCollection.OnftIds[i]
+	// get random nft
+	i := r.Intn(nftsLen)
+	_nft := onfts[i]
 
-	ownerAddress, _ := sdk.AccAddressFromBech32(owner.Address)
-	return ownerAddress, denomID, nftID
+	return _nft.GetOwner(), denomID, nftID
 }
 
 func getRandomDenom(ctx sdk.Context, k keeper.Keeper, r *rand.Rand) (types.Denom, error) {

x/onft/types/validations.go

@@ -101,7 +101,6 @@ func ValidateMediaURI(uri string) error {
 			ErrInvalidURI,
 			"invalid uri %s, media uri should not be empty",
 			uri,
-			0,
 		)
 	}
 	if len(uri) > MaxURILen {