Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing authNonce in propose-update-diddoc API response #13

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

yoongyu-lee
Copy link
Member

Description

Fixed a bug in the P141-user DID Document update protocol's propose-update-diddoc API where the response message did not include authNonce.

Related Issue (Optional)

�N/A

Changes

  • Added authNonce to ProposeUpdateDidDocResDto
  • Modified the response message of propose-update-diddoc to include authNonce

Screenshots (Optional)

N/A

Additional Comments (Optional)

N/A

mikyung-lee and others added 7 commits October 28, 2024 15:12
Merge develop branch into main
* docs(license): Modify file name from License-dependencies.md to dependencies-license.md and update the guide to reflect the changes.

Additionally, removed Korean comments from the Dockerfile for consistency and clarity.

* chore: add/modify Github Action

---------

Co-authored-by: mklee <[email protected]>
Co-authored-by: gwnam <[email protected]>
* docs(license): Modify file name from License-dependencies.md to dependencies-license.md and update the guide to reflect the changes.

Additionally, removed Korean comments from the Dockerfile for consistency and clarity.

* chore: add/modify Github Action

* docs: Added new "Demo Videos" section to README.md

---------

Co-authored-by: YoonGyu Lee <[email protected]>
Co-authored-by: mklee <[email protected]>
Co-authored-by: gwnam <[email protected]>
Resolve merge conflict in `README.md` between `main` and `develop` branches
Fix Build Workflow and Update README with Demo Videos and Korean Translation
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jinhwankim6557 jinhwankim6557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikyung-lee mikyung-lee merged commit 94b00dd into develop Nov 21, 2024
3 checks passed
@mikyung-lee mikyung-lee deleted the feature/update-diddoc-authnonce branch November 21, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants