Merge pull request #341 from Once-Upon/feature/ou-2278-transaction-co…

…ntext-is-incorrect-for feat: update eth payments in erc1155Purchase
Once-Upon · Apr 26, 2024 · 77dfd9f · 77dfd9f
2 parents 89b6c86 + be5ddd5
commit 77dfd9f
Show file tree

Hide file tree

Showing 4 changed files with 1,992 additions and 7 deletions.
diff --git a/src/contextualizers/heuristics/erc1155Purchase/erc1155Purchase.spec.ts b/src/contextualizers/heuristics/erc1155Purchase/erc1155Purchase.spec.ts
@@ -1,8 +1,10 @@
 import { Transaction } from '../../../types';
-import { detect } from './erc1155Purchase';
+import { detect, generate } from './erc1155Purchase';
 import erc1155Purchase0x156df9f7 from '../../test/transactions/erc1155Purchase-0x156df9f7.json';
 import erc1155Sale0x16b2334d from '../../test/transactions/erc1155Sale-0x16b2334d.json';
+import erc1155Purchase0xc6c925c0 from '../../test/transactions/erc1155Purchase-0xc6c925c0.json';
 import catchall0xc35c01ac from '../../test/transactions/catchall-0xc35c01ac.json';
+import { contextSummary } from '../../../helpers/utils';
 
 describe('ERC1155 Purchase', () => {
   it('Should detect ERC1155 Purchase transaction', () => {
@@ -15,6 +17,31 @@ describe('ERC1155 Purchase', () => {
       erc1155Sale0x16b2334d as unknown as Transaction,
     );
     expect(isERC1155Purchase2).toBe(true);
+
+    const isERC1155Purchase3 = detect(
+      erc1155Purchase0xc6c925c0 as unknown as Transaction,
+    );
+    expect(isERC1155Purchase3).toBe(true);
+  });
+
+  it('Should generate context for ERC1155 Purchase', () => {
+    const erc1155Purchase1 = generate(
+      erc1155Purchase0xc6c925c0 as unknown as Transaction,
+    );
+    expect(erc1155Purchase1.context?.summaries?.en.title).toBe('NFT Purchase');
+    expect(erc1155Purchase1.context?.variables?.tokenOrTokens['token']).toBe(
+      '0x6541dc28acb78e1b024f5ffe1c840bc3e6fcf36a',
+    );
+    expect(erc1155Purchase1.context?.variables?.tokenOrTokens['tokenId']).toBe(
+      '1',
+    );
+    expect(erc1155Purchase1.context?.variables?.tokenOrTokens['value']).toBe(
+      '1',
+    );
+    const desc1 = contextSummary(erc1155Purchase1.context);
+    expect(desc1).toBe(
+      '0x15cc6926a4bea1eb176a738f7a8c63e65b437f84 BOUGHT 1 0x6541dc28acb78e1b024f5ffe1c840bc3e6fcf36a #1 for 0.00824 ETH from 0x1ddbaec4f1d056bcb6a6e7a6f2e8790ff2ae552b',
+    );
   });
 
   it('Should not detect ERC1155 Purchase transaction', () => {

diff --git a/src/contextualizers/heuristics/erc1155Purchase/erc1155Purchase.ts b/src/contextualizers/heuristics/erc1155Purchase/erc1155Purchase.ts
@@ -79,7 +79,7 @@ export function detect(transaction: Transaction): boolean {
   return false;
 }
 
-function generate(transaction: Transaction): Transaction {
+export function generate(transaction: Transaction): Transaction {
   if (!transaction.assetTransfers || !transaction.netAssetTransfers) {
     return transaction;
   }
@@ -98,10 +98,12 @@ function generate(transaction: Transaction): Transaction {
 
   const totalERC20Payment: Record<string, ERC20Asset> = computeERC20Price(
     erc20Payments,
-    [transaction.from],
+    receivingAddresses,
   );
-  const totalETHPayment = computeETHPrice(ethPayments, [transaction.from]);
-  const totalAssets = erc20Payments.length + ethPayments.length;
+  const totalETHPayment = computeETHPrice(ethPayments, receivingAddresses);
+  const totalAssets =
+    Object.keys(totalERC20Payment).length +
+    (totalETHPayment > BigInt(0) ? 1 : 0);
 
   transaction.context = {
     variables: {