Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add asset transfers in idm #368

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ponyjackal
Copy link
Contributor

No description provided.

@ponyjackal ponyjackal requested a review from pcowgill May 7, 2024 23:42
Copy link
Contributor

@pcowgill pcowgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordanmessina @ponyjackal I'm realizing that with the approach, because the message can be so long, the amount will rarely show up with the approach where we put the amount at the end. @jordanmessina let's think about how we might update the requirements to make this work better.

@pcowgill pcowgill added the blocked Don't merge yet label May 22, 2024
Copy link
Contributor

@pcowgill pcowgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ponyjackal For the message variable, include truncate: true in the object

@ponyjackal ponyjackal requested a review from pcowgill June 11, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Don't merge yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants