Key changes to CropXYZ function calls and events #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ponyjackal Could you take a look at the build failure? |
pcowgill
reviewed
Jul 1, 2024
pcowgill
reviewed
Jul 1, 2024
pcowgill
reviewed
Jul 1, 2024
pcowgill
reviewed
Jul 1, 2024
pcowgill
reviewed
Jul 1, 2024
pcowgill
reviewed
Jul 1, 2024
pcowgill
reviewed
Jul 1, 2024
pcowgill
reviewed
Jul 1, 2024
| category: 'PROTOCOL_1', | ||
| en: { | ||
| title: `Gold`, | ||
| default: '[[player]][[clearedHarvest]]plots[[plotId]]', |
There was a problem hiding this comment.
We'll keep this like this for now, but an open question is whether we want to render the player given their non-trivial use of account abstraction, etc. When we fully support AA in this repo soon, we'll definitely include the right player.
pcowgill
reviewed
Jul 1, 2024
pcowgill
reviewed
Jul 1, 2024
pcowgill
reviewed
Jul 1, 2024
pcowgill
requested changes
Jul 1, 2024
pcowgill
changed the title
pcowgill
reviewed
Jul 2, 2024
| // ); | ||
| // expect(transaction2.context?.summaries?.en.title).toBe('CropXYZ'); | ||
| // expect(contextSummary(transaction2.context)).toBe( | ||
| // '0x402533d5240A0c51e02d3714C0D0A057384D4872 HARVESTED_PLOT 257 0x9c82ca3332898bea9c9fa5f9642ba4a4628e1321', |
There was a problem hiding this comment.
Suggested change
| // '0x402533d5240A0c51e02d3714C0D0A057384D4872 HARVESTED_PLOT 257 0x9c82ca3332898bea9c9fa5f9642ba4a4628e1321', | |
| // '0x402533d5240A0c51e02d3714C0D0A057384D4872 CLEARED_HARVEST', |
pcowgill
approved these changes
Jul 2, 2024
pcowgill
deleted the
feature/ou-2595-key-changes-to-gold-function-calls-and-events
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve OU-2666
Resolve OU-2667