feat: alph chain set "group" with optional (#375)

* feat: alph chain set "group" with optional * fix: change || to ?? * fix: ignore group
OneKeyHQ · Oct 10, 2024 · 902fcec · 902fcec
1 parent 3b1929d
commit 902fcec
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 4 deletions.
diff --git a/packages/connect-examples/expo-example/src/data/alephium.ts b/packages/connect-examples/expo-example/src/data/alephium.ts
@@ -9,6 +9,7 @@ const api: PlaygroundProps[] = [
         title: 'Get address',
         value: {
           path: "m/44'/1234'/0'/0/0",
+          includePublicKey: true,
           showOnOneKey: false,
           group: 0,
         },
@@ -19,11 +20,13 @@ const api: PlaygroundProps[] = [
           bundle: [
             {
               path: "m/44'/1234'/0'/0/0",
+              includePublicKey: true,
               showOnOneKey: false,
               group: 0,
             },
             {
               path: "m/44'/1234'/0'/0/1",
+              includePublicKey: true,
               showOnOneKey: false,
               group: 0,
             },

diff --git a/packages/connect-examples/expo-example/src/data/allnetwork.ts b/packages/connect-examples/expo-example/src/data/allnetwork.ts
@@ -208,7 +208,9 @@ const api: PlaygroundProps[] = [
             {
               network: 'alph',
               path: "m/44'/1234'/0'/0/0",
+              includePublicKey: true,
               showOnOneKey: false,
+              group: 0,
             },
             {
               network: 'nostr',

diff --git a/packages/core/src/api/alephium/AlephiumGetAddress.ts b/packages/core/src/api/alephium/AlephiumGetAddress.ts
@@ -36,7 +36,8 @@ export default class AlephiumGetAddress extends BaseMethod<HardwareAlephiumGetAd
         address_n: addressN,
         show_display: showOnOneKey,
         include_public_key: batch.includePublicKey ?? false,
-        target_group: batch.group,
+        // When group is 'null', the 'group' parameter will not be sent
+        ...(batch.group !== null && { target_group: batch.group ?? 0 }),
       });
     });
   }

diff --git a/packages/core/src/types/api/alephiumGetAddress.ts b/packages/core/src/types/api/alephiumGetAddress.ts
@@ -11,7 +11,7 @@ export type AlephiumGetAddressParams = {
   path: string | number[];
   showOnOneKey?: boolean;
   includePublicKey?: boolean;
-  group: number;
+  group: number | undefined | null;
 };
 
 export declare function alephiumGetAddress(

diff --git a/packages/hd-web-sdk/src/iframe/builder.ts b/packages/hd-web-sdk/src/iframe/builder.ts
@@ -29,8 +29,8 @@ export const init = async (settings: any) => {
     }
   }
 
-  const manifest = `version=${settings.version as string}`;
-  const src = `${settings.iframeSrc as string}?${manifest}`;
+  // const manifest = `version=${settings.version as string}`;
+  const src = `${settings.iframeSrc as string}`;
 
   instance.setAttribute('src', src);