Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allnetwork method #344

Merged
merged 3 commits into from
Aug 26, 2024
Merged

feat: allnetwork method #344

merged 3 commits into from
Aug 26, 2024

Conversation

ByteZhang1024
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Jul 22, 2024

PR Summary

  • Version Update
    The version numbers have been increased in the package.json files of the packages such as 'electron-example', 'expo-example', and 'core'. This is a routine procedure to keep track of updates and changes in our applications.

  • Addition of new file - 'allnetwork.ts'
    A new file called 'allnetwork.ts' has been added to the 'expo-example/src/data' directory. This may contain the data related to networks in the 'expo-example' application.

  • Addition of new file - 'AllNetworkGetAddress.ts'
    A new file 'AllNetworkGetAddress.ts' was also added in the directory 'core/src/api/allnetwork'. This file might contain a function named 'AllNetworkGetAddress'.

  • Update in 'ApiPayloadScreen.tsx' file
    The file 'ApiPayloadScreen.tsx', located within the 'expo-example/src/views' directory was revised to add a new section for the 'AllNetwork API'. This means that our 'expo-example' application now has a user interface for interacting with the 'AllNetwork API'.

  • addition of 'allNetworkGetAddress' method
    Our application now includes a new method 'allNetworkGetAddress' in the 'api/index.ts' file within 'core/src/api' directory. This is likely to facilitate getting addresses from all networks.

  • Handling 'allNetworkGetAddress' method
    The 'allNetworkGetAddress' method is now handled by the 'core/src/core' directory, specifically in the 'index.ts' file of the said directory.

  • Injecting 'allNetworkGetAddress' API method
    Our 'core/src' directory, within the 'inject.ts' file, now includes the 'allNetworkGetAddress' API method. This encapsulates the logic to get the addresses from all networks.

  • Addition of 'allNetworkGetAddress.ts' file in 'types/api' directory
    A new file named 'allNetworkGetAddress.ts' was added to 'types/api' directory. This means the 'allNetworkGetAddress' feature is also covered through TypeScript’s static types.

  • Addition of new types
    New types called 'AllNetworkAddressParams' and 'AllNetworkGetAddressParams' were added in 'export.ts' file. Additionally, the 'CoreApi' type in 'index.ts' file has been supplemented with 'allNetworkGetAddress' function.

  • Updated Dependencies
    The version numbers of dependencies in various package.json files such as 'hd-ble-sdk', 'hd-common-connect-sdk', 'hd-transport-http', 'hd-transport-lowlevel', 'hd-transport-react-native', 'hd-transport-webusb', 'hd-transport' and 'hd-web-sdk' were updated. This ensures our applications are up-to-date with the latest functionalities and security fixes from these packages.

Copy link

socket-security bot commented Jul 22, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@ByteZhang1024 ByteZhang1024 force-pushed the feat/allnetwork branch 2 times, most recently from 9dae7c4 to 7017e54 Compare August 21, 2024 08:34
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@onekeyfe/[email protected]), npm/@onekeyfe/[email protected]), npm/@onekeyfe/[email protected]), npm/@onekeyfe/[email protected])

View full report↗︎

@ByteZhang1024 ByteZhang1024 marked this pull request as ready for review August 26, 2024 03:49
@ByteZhang1024 ByteZhang1024 enabled auto-merge (squash) August 26, 2024 03:49
@ByteZhang1024 ByteZhang1024 merged commit 9753199 into onekey Aug 26, 2024
7 checks passed
@ByteZhang1024 ByteZhang1024 deleted the feat/allnetwork branch August 26, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants