Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Identity Verification iOS Implementation #1033

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Nov 14, 2024

Description

One Line Summary

Implement identity verification functionality to our Cordova SDK.

Details

Implement identity verification functionality to our Cordova SDK with JWT (JSON Web Token) that manage a specific User, their Subscriptions, and Identities, if enabled using OneSignal dashboard.

Motivation

The OneSignal Identity Verification feature only exists today for the Player model; we want to add this functionality to the User Model SDKs.

Scope

This PR only encapsulates changes to the Cordova wrapper and iOS bridge. A future PR will include Android implementation.

Testing

Manual testing

Testing was done with the iOS beta release v. 5.3.0-beta-01. Another round of testing will be completed when out of pre-release.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

- Token added as parameter to login
- updateUserJwt
- UserJwtInvalidatedEvent
- Add & Remove Listener methods
- new methods updateUserJwt and addUserJwtInvalidatedListener added to the bridge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant