Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration guide fixes post 5.0.0 release #1541

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Migration guide fixes post 5.0.0 release #1541

merged 6 commits into from
Sep 27, 2023

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Aug 22, 2023 •
edited by niels-s
Loading

Description

One Line Summary

Migration guide fixes post 5.0.0 release

Details

Motivation

Address formatting issues, incorrect scope for login and logout methods, and add more details regarding migration from 3.x.x to 5.x.x, particularly around NSE updates.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

nan-li and others added 4 commits August 20, 2023 18:42
@nan-li
Fix migration guide table formatting
ccbf17b 
* Was previously missing a vertical bar `|` in the table that prevented the `permissionNative` row from rendering
@jennantilla
Update migration instructions for iOS
f1fac3e 
* Increase OneSignalXCFramework pod to '>= 5.0', '< 6.0'
* Update NotificationService file with new native code
@jennantilla
Change scope for login/logout method
a95127e 
* Migration guide mistakenly had login and logout on User namespace
@jennantilla
Fix formatting on NSE changes instructions
4c773f8
emawby
emawby suggested changes Aug 22, 2023
View reviewed changes
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
MIGRATION_GUIDE.md Outdated Show resolved Hide resolved
@nan-li
Misc migration guide updates
4189a99 
* react native SDK is going from v4 to v5
* Add awaits and remove awaits
* Update code samples
* URL update
@nan-li
Copy link
Contributor

nan-li commented Sep 26, 2023 •
edited
Loading

I added one more commit for migration guide updates

@nan-li nan-li force-pushed the migration_guide_fixes_post_5.0.0_release branch from c503c99 to 4189a99 Compare September 26, 2023 20:37
@nan-li nan-li merged commit 74db2b0 into major_release_5.0.0 Sep 27, 2023
4 checks passed
@nan-li nan-li mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emawby emawby emawby approved these changes

@nan-li nan-li nan-li approved these changes

@jkasten2 jkasten2 Awaiting requested review from jkasten2

@shepherd-l shepherd-l Awaiting requested review from shepherd-l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennantilla @nan-li @emawby