Add canRequestPermission to Android #1570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
OneSignal.Notifications.canRequestPermission()
has been fixed for Android in OneSignal/OneSignal-Android-SDK#1798, make it available in React Native SDK.Details
Motivation
Add
OneSignal.Notifications.canRequestPermission()
functionality to Android. It was previously iOS-only, with Android always returningtrue
.Scope
Adds
OneSignal.Notifications.canRequestPermission()
functionality to Android.Note that the method
OneSignal.Notifications.canRequestPermission()
returns whether or not the device has been prompted for push already, and may not indicate on Android whether or not a push prompt will display.Prior, we didn't document this method as iOS-only.
Testing
Manual testing
Testing on Android emulator API 33:
canRequestPermission = true
canRequestPermission = false
which is correctAffected code checklist
Checklist
Overview
Testing
Final pass
This change is