Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUI] Fix isVersionNewer handling and remove some legacy code #2329

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

dragonbane0
Copy link
Collaborator

@dragonbane0 dragonbane0 commented Nov 8, 2024

Fixes version comparisons on the web builds for auto settings import. Function was severely outdated at this point

@dragonbane0 dragonbane0 self-assigned this Nov 8, 2024
@dragonbane0 dragonbane0 added the Type: Bug Something isn't working label Nov 8, 2024
@fenhl
Copy link
Collaborator

fenhl commented Nov 18, 2024

Does this PR still need testing or can it be merged as-is?

@TreZc0
Copy link
Member

TreZc0 commented Nov 18, 2024

can be merged

@fenhl fenhl added this to the next milestone Nov 18, 2024
@fenhl fenhl merged commit 5ff79d6 into OoTRandomizer:Dev Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants