Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various changes to precompleted dungeons #2330

Open
wants to merge 2 commits into
base: Dev
Choose a base branch
from
Open

Various changes to precompleted dungeons #2330

wants to merge 2 commits into from

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented Nov 9, 2024

  • Fixes a bug reported today on Discord where precompleted dungeon rewards did not account for boss ER
  • Makes precompleted dungeon rewards compatible with reward shuffle (rewards in side dungeons or the overworld will have no effect)
  • Changes internal terminology from empty to precompleted to avoid potential confusion, as previously discussed at Cross out pre-completed dungeons in dungeon info menu #2244 (comment)
  • Removes the EmptyDungeons and EmptyDungeonInfo classes in favor of making World.precompleted_dungeons a simple dict[str, bool] like World.dungeon_mq
    • The existence of the EmptyDungeonInfo.boss_name attribute contributed to the aforementioned boss ER bug, it is replaced with calculating the hint area when needed
  • Minor drive-by code style fixes

@fenhl fenhl added Type: Bug Something isn't working Status: Needs Review Someone should be looking at it Component: Randomizer Core Generally the core functions of the python Component: Setting specific to setting(s) Component: Hints related to how we help the player Status: Needs Testing Probably should be tested Type: Maintenance Code style, infrastructure, updating dependencies labels Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Hints related to how we help the player Component: Randomizer Core Generally the core functions of the python Component: Setting specific to setting(s) Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Type: Bug Something isn't working Type: Maintenance Code style, infrastructure, updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fenhl