JSON API documentation rfc #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Debski <[email protected]>
pdebski21
force-pushed
the
master
branch
2 times, most recently
from
771399a
to
84efa8c
Compare
Deixx
requested changes
Nov 5, 2021
| - for each core in cache: | ||
| - Core details | ||
| ```json | ||
| [ |
There was a problem hiding this comment.
do we want to have all the information here? cache.get_list has lots of information from cache.info.get
There was a problem hiding this comment.
Most likely limiting info in list caches to minimum is good way to go.
| }, | ||
| "Cleaning policy": "alru", | ||
| "Promotion policy": "always", | ||
| "Cache line size [KiB]": 4096, |
There was a problem hiding this comment.
4096 KiB is a lot for a cache line size ;)
rafalste
reviewed
Nov 5, 2021
|
|
||
| ```json | ||
| { | ||
| "header": { |
There was a problem hiding this comment.
Wouldn't it be better to remove header group and put command at the top (at the same level as params)?
pdebski21
force-pushed
the
master
branch
4 times, most recently
from
8291c7b
to
aa0210f
Compare
Co-authored-by: Daniel Madej <[email protected]> Signed-off-by: Piotr Debski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Debski [email protected]