-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add todo notes on hardcoded VITO references Open-EO/openeo-python-dri…
- Loading branch information
Showing
3 changed files
with
3 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -158,6 +158,7 @@ def main(): | |
help='Classpath used to launch the Java Gateway') | ||
parser.add_argument("--py4j-maximum-heap-size", default="1G", | ||
help='Maximum heap size for the Java Gateway JVM') | ||
# TODO: eliminate hardcoded (VITO) defaults? Open-EO/openeo-python-driver#275 | ||
parser.add_argument("--principal", default="[email protected]", help="Principal to be used to login to KDC") | ||
parser.add_argument("--keytab", default="openeo-deploy/mep/openeo.keytab", | ||
help="Path to the file that contains the keytab for the principal") | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -682,6 +682,7 @@ def parse_cli_args(self, args: Optional[List[str]] = None) -> argparse.Namespace | |
) | ||
parser.add_argument( | ||
"--principal", | ||
# TODO: eliminate hardcoded (VITO) defaults? Open-EO/openeo-python-driver#275 | ||
default="[email protected]", | ||
help="Principal to be used to login to KDC", | ||
) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,7 +58,7 @@ def login_jwt(self, access_token: str) -> str: | |
@retry(exceptions=VaultLoginError, tries=4, delay=2, backoff=4, logger=_log) | ||
def login_kerberos( | ||
self, | ||
# TODO: eliminate hardcoded defaults? | ||
# TODO: eliminate hardcoded (VITO) defaults? Open-EO/openeo-python-driver#275 | ||
principal: str = "[email protected]", | ||
keytab: str = "/opt/openeo.keytab", | ||
) -> str: | ||
|