Skip to content

Commit

Permalink
Add todo notes on hardcoded VITO references Open-EO/openeo-python-dri…
Browse files Browse the repository at this point in the history
  • Loading branch information
soxofaan committed May 16, 2024
1 parent 630439c commit f2c0739
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions openeogeotrellis/async_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ def main():
help='Classpath used to launch the Java Gateway')
parser.add_argument("--py4j-maximum-heap-size", default="1G",
help='Maximum heap size for the Java Gateway JVM')
# TODO: eliminate hardcoded (VITO) defaults? Open-EO/openeo-python-driver#275
parser.add_argument("--principal", default="[email protected]", help="Principal to be used to login to KDC")
parser.add_argument("--keytab", default="openeo-deploy/mep/openeo.keytab",
help="Path to the file that contains the keytab for the principal")
Expand Down
1 change: 1 addition & 0 deletions openeogeotrellis/job_tracker_v2.py
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,7 @@ def parse_cli_args(self, args: Optional[List[str]] = None) -> argparse.Namespace
)
parser.add_argument(
"--principal",
# TODO: eliminate hardcoded (VITO) defaults? Open-EO/openeo-python-driver#275
default="[email protected]",
help="Principal to be used to login to KDC",
)
Expand Down
2 changes: 1 addition & 1 deletion openeogeotrellis/vault.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def login_jwt(self, access_token: str) -> str:
@retry(exceptions=VaultLoginError, tries=4, delay=2, backoff=4, logger=_log)
def login_kerberos(
self,
# TODO: eliminate hardcoded defaults?
# TODO: eliminate hardcoded (VITO) defaults? Open-EO/openeo-python-driver#275
principal: str = "[email protected]",
keytab: str = "/opt/openeo.keytab",
) -> str:
Expand Down

0 comments on commit f2c0739

Please sign in to comment.